fix: excess render calls for the FileItem on "Add more"

uploadcare · Apr 12, 2022 · 655747a · 655747a
1 parent 6a78077
commit 655747a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/blocks/FileItem/FileItem.js b/blocks/FileItem/FileItem.js
@@ -69,9 +69,10 @@ export class FileItem extends Block {
   }
 
   initCallback() {
+    super.initCallback();
     this.bindCssData('--cfg-thumb-size');
     this.defineAccessor('entry-id', (id) => {
-      if (!id) {
+      if (!id || id === this.uid) {
         return;
       }
       /** @type {String} */

diff --git a/blocks/UploadList/UploadList.js b/blocks/UploadList/UploadList.js
@@ -124,11 +124,15 @@ export class UploadList extends Block {
       let fr = document.createDocumentFragment();
       Object.values(this._renderMap).forEach((el) => fr.appendChild(el));
       this.ref.files.replaceChildren(fr);
-      Object.entries(this._renderMap).forEach(([id, el]) => {
+      Object.keys(this._renderMap).forEach((id) => {
+        /** @type {Block} */
+        let el = this._renderMap[id];
         // rendering components async improves initial list render time a bit
         setTimeout(() => {
           el['entry-id'] = id;
-          el.render();
+          if (!el.innerHTML) {
+            el.render();
+          }
         });
       });
     });