Skip to content

Commit 97f13e3

Browse files
authored
feat: added titles a11y in buttons of uc-activity-header (#748)
1 parent d0bb581 commit 97f13e3

File tree

4 files changed

+21
-9
lines changed

4 files changed

+21
-9
lines changed

blocks/CameraSource/CameraSource.js

+7-2
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ export class CameraSource extends UploaderBlock {
215215

216216
CameraSource.template = /* HTML */ `
217217
<uc-activity-header>
218-
<button type="button" class="uc-mini-btn" set="onclick: *historyBack">
218+
<button type="button" class="uc-mini-btn" set="onclick: *historyBack" l10n="@title:back">
219219
<uc-icon name="back"></uc-icon>
220220
</button>
221221
<div set="@hidden: !cameraSelectHidden">
@@ -227,7 +227,12 @@ CameraSource.template = /* HTML */ `
227227
set="$.options: cameraSelectOptions; @hidden: cameraSelectHidden; onchange: onCameraSelectChange"
228228
>
229229
</uc-select>
230-
<button type="button" class="uc-mini-btn uc-close-btn" set="onclick: *closeModal">
230+
<button
231+
type="button"
232+
class="uc-mini-btn uc-close-btn"
233+
set="onclick: *closeModal"
234+
l10n="@title:a11y-activity-header-button-close"
235+
>
231236
<uc-icon name="close"></uc-icon>
232237
</button>
233238
</uc-activity-header>

blocks/ExternalSource/ExternalSource.js

+7-2
Original file line numberDiff line numberDiff line change
@@ -249,14 +249,19 @@ export class ExternalSource extends UploaderBlock {
249249

250250
ExternalSource.template = /* HTML */ `
251251
<uc-activity-header>
252-
<button type="button" class="uc-mini-btn" set="onclick: *historyBack">
252+
<button type="button" class="uc-mini-btn" set="onclick: *historyBack" l10n="@title:back">
253253
<uc-icon name="back"></uc-icon>
254254
</button>
255255
<div>
256256
<uc-icon set="@name: activityIcon"></uc-icon>
257257
<span>{{activityCaption}}</span>
258258
</div>
259-
<button type="button" class="uc-mini-btn uc-close-btn" set="onclick: *historyBack">
259+
<button
260+
type="button"
261+
class="uc-mini-btn uc-close-btn"
262+
set="onclick: *historyBack"
263+
l10n="@title:a11y-activity-header-button-close"
264+
>
260265
<uc-icon name="close"></uc-icon>
261266
</button>
262267
</uc-activity-header>

blocks/Icon/Icon.js

-3
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ export class Icon extends Block {
99
...this.init$,
1010
name: '',
1111
href: '',
12-
title: '',
1312
};
1413
}
1514

@@ -33,12 +32,10 @@ export class Icon extends Block {
3332

3433
Icon.template = /* HTML */ `
3534
<svg ref="svg" xmlns="http://www.w3.org/2000/svg">
36-
<title>{{title}}</title>
3735
<use set="@href: href;"></use>
3836
</svg>
3937
`;
4038

4139
Icon.bindAttributes({
4240
name: 'name',
43-
title: 'title',
4441
});

blocks/UrlSource/UrlSource.js

+7-2
Original file line numberDiff line numberDiff line change
@@ -38,14 +38,19 @@ export class UrlSource extends UploaderBlock {
3838

3939
UrlSource.template = /* HTML */ `
4040
<uc-activity-header>
41-
<button type="button" class="uc-mini-btn" set="onclick: *historyBack">
41+
<button type="button" class="uc-mini-btn" set="onclick: *historyBack" l10n="@title:back">
4242
<uc-icon name="back"></uc-icon>
4343
</button>
4444
<div>
4545
<uc-icon name="url"></uc-icon>
4646
<span l10n="caption-from-url"></span>
4747
</div>
48-
<button type="button" class="uc-mini-btn uc-close-btn" set="onclick: *closeModal">
48+
<button
49+
type="button"
50+
class="uc-mini-btn uc-close-btn"
51+
set="onclick: *closeModal"
52+
l10n="@title:a11y-activity-header-button-close"
53+
>
4954
<uc-icon name="close"></uc-icon>
5055
</button>
5156
</uc-activity-header>

0 commit comments

Comments
 (0)