Skip to content

Commit 70a9b2b

Browse files
committed
fix(cloud-image-editor): little memory leak where cloud image editor was holding some references that prevents from context destroying
1 parent ef663fa commit 70a9b2b

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

abstract/Block.js

+2
Original file line numberDiff line numberDiff line change
@@ -209,6 +209,8 @@ export class Block extends BaseComponent {
209209

210210
/** @protected */
211211
destroyCallback() {
212+
super.destroyCallback();
213+
212214
let blocksRegistry = this.blocksRegistry;
213215
blocksRegistry?.delete(this);
214216

blocks/CloudImageEditor/src/elements/slider/SliderUi.js

+1
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,7 @@ export class SliderUi extends Block {
163163
}
164164

165165
destroyCallback() {
166+
super.destroyCallback();
166167
this._observer?.disconnect();
167168
}
168169
}

0 commit comments

Comments
 (0)