fix(file-item): call IntersectionObserver.unobserve in the right places

uploadcare · Jul 28, 2022 · 3216ad7 · 3216ad7
1 parent 7f6977a
commit 3216ad7
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/blocks/FileItem/FileItem.js b/blocks/FileItem/FileItem.js
@@ -41,6 +41,7 @@ export class FileItem extends UploaderBlock {
     let [entry] = entries;
     if (entry.isIntersecting && !this.innerHTML) {
       this.render();
+      this._observer?.unobserve(this);
     }
     if (entry.intersectionRatio === 0) {
       clearTimeout(this._thumbTimeoutId);
@@ -155,7 +156,6 @@ export class FileItem extends UploaderBlock {
         if (!uuid) {
           return;
         }
-        this._observer.unobserve(this);
         this.setAttribute('loaded', '');
 
         if (this.entry.getValue('isImage')) {
@@ -226,7 +226,7 @@ export class FileItem extends UploaderBlock {
 
   destroyCallback() {
     FileItem.activeInstances.delete(this);
-    // this._observer.unobserve(this);
+    this._observer?.unobserve(this);
     clearTimeout(this._thumbTimeoutId);
   }