Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jekyll-polyglot removes any images generated by jekyll_picture_tag #152

Open
kylekirkby opened this issue Jan 6, 2022 · 3 comments
Open

Comments

@kylekirkby
Copy link

Hi @untra ,

We're using the jekyll_picture_tag plugin to generate webp images for our sites. With the addition of jekyll-polyglot this has broken. Jekyll_picture_tag places the generated images inside the assets/images of the output site folder as the site is building. When the site build ends, it appears that jekyll-polylgot is removing all of these generated images and simply replacing the folder assets/images folder that exists in the base of the repo.

Any ideas how we can stop this happening?

As a work-around I've had to set the output folder for generated images to a folder at the root of the repo (outside of the build folder). This then gets copied in as expected.

# -------- jekyll_picture_tag --------
picture:
  nomarkdown: false
  suppress_warnings: true
  source: ""
  output: "../generated"
  relative_url: true
  disabled: false

# Jekyll-polyglot
i18n_enabled: true
languages: ["en", "ja"]
default_lang: "en"
exclude_from_localization:
  ["javascript", "images", "css", "public", "assets", "generated"]
parallel_localization: false
@kylekirkby
Copy link
Author

@timbms
Copy link

timbms commented Jul 2, 2024

Is there an update to this issue?

@jimboolio
Copy link

I do not encounter this issue, I'm using both plugins and images do show up on translated blog post. Here is my working code, sorry it's a mess, it's my first time trying Jekyll: https://codeberg.org/jimbo/web/src/commit/d9a5add6c516e315c8123e5eba765d9ab923a576d720a91078cc434e103444d2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants