Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds heroes seeding to the makefile #878

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yokwejuste
Copy link
Collaborator

Summary

Description of PR here...
Closes #876

Changes

  • A seeder for the heroes section.

Screenshots

After running the backend, on opening the frontend we now have this 🎉
image

@coderatomy
Copy link
Collaborator

Nice @yokwejuste

@yokwejuste
Copy link
Collaborator Author

Nice @yokwejuste

Thanks @coderatomy 🙏

@brrkrmn
Copy link
Collaborator

brrkrmn commented Oct 12, 2023

Thanks @yokwejuste ☺️, this will be very useful

@yokwejuste
Copy link
Collaborator Author

Thanks @yokwejuste ☺️, this will be very useful

Thanks @brrkrmn

@tuxology
Copy link
Member

I believe we don't need this since absence of a header is not creating any critical issues in a newly installed Zubhub? We can keep this open and mark this low priority. Also, we don't want to add any hardcoded values for images etc. in the Makefile

@yokwejuste
Copy link
Collaborator Author

I believe we don't need this since absence of a header is not creating any critical issues in a newly installed Zubhub? We can keep this open and mark this low priority. Also, we don't want to add any hardcoded values for images etc. in the Makefile

Maybe you might suggest something. We had issues working on the project and were unable to view the hero section to make some edits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: local setup not matching the production version
4 participants