Skip to content

yaml and cli#708

Closed
darkacorn wants to merge 1 commit into
unslothai:mainfrom
darkacorn:yaml_and_cli_refactor
Closed

yaml and cli#708
darkacorn wants to merge 1 commit into
unslothai:mainfrom
darkacorn:yaml_and_cli_refactor

Conversation

@darkacorn

Copy link
Copy Markdown

should work out of the box - seb please rev/ daniel and mike please comments on the idea

as for why its pretty straight forward - central config vs over chaneing files - and more maintainable via config file vs params passed in

@darkacorn

Copy link
Copy Markdown
Author

btw this pr is premliminary and wip very much do not merge right away

@danielhanchen

Copy link
Copy Markdown
Member

Interesting and great work!!

@bet0x

bet0x commented Jul 5, 2024

Copy link
Copy Markdown
Contributor

It was suggested in the GitHub pull request #623 (#623), but it seemed to be a less-than-ideal proposal. I hope this gets merged, as passing variables via the command line is quite outdated.

@darkacorn

Copy link
Copy Markdown
Author

elaborate how that's a bad idea ? it takes nothing away

@Datta0

Datta0 commented Jul 13, 2024

Copy link
Copy Markdown
Collaborator

Just a thought, should we use something like typer instead of argparse?

@darkacorn

Copy link
Copy Markdown
Author

actually very interresting . as it has the same syntax as fastapi .. did not know typer before gotta look into that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants