-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
ci: deterministic check for studio/frontend dep removals #5478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+2,845
−0
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
f3f34b7
ci: deterministic check for studio/frontend dep removals
danielhanchen 667cee6
scripts: harden frontend dep removal check + adversarial suite
danielhanchen 231d4f1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 52cf06b
scripts: detect bin references in package.json scripts
danielhanchen 1770525
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] d8c4840
scripts: detect package.json field references to packages
danielhanchen e83e325
scripts: enumerate dead deps in studio/frontend
danielhanchen 2660f40
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 340f16c
ci: fetch base ref before running dep removal safety check
danielhanchen bdf6f84
ci: address bot review on PR 5478
danielhanchen d0a5d5a
ci: address 10x reviewer findings on dep removal safety check
danielhanchen 8d1b21c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 6b70e72
ci: address 4x Opus reviewer findings on dep removal check
danielhanchen 418b63b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new CI step executes
scripts/check_frontend_dep_removal.pyandtests/studio/test_frontend_dep_removal.py, but the workflow'spull_request.pathsfilter only includesstudio/frontend/**and the workflow file itself. As a result, PRs that modify either checker file can bypass this job entirely, allowing regressions in the new safety gate to merge without running its own CI.Useful? React with 👍 / 👎.