Skip to content

split venv_t5 into tiered 5.3.0/5.5.0 and fix trust_remote_code#4878

Merged
rolandtannous merged 18 commits into
mainfrom
fix/transformers-v5-tiers
Apr 7, 2026
Merged

split venv_t5 into tiered 5.3.0/5.5.0 and fix trust_remote_code#4878
rolandtannous merged 18 commits into
mainfrom
fix/transformers-v5-tiers

Conversation

@rolandtannous

@rolandtannous rolandtannous commented Apr 6, 2026

Copy link
Copy Markdown

Summary

  • Split single .venv_t5 (transformers 5.5.0) into .venv_t5_530 (5.3.0) and .venv_t5_550 (5.5.0)
  • Qwen3.5, Ministral-3, GLM-4.7-Flash etc. use 5.3.0; Gemma 4 uses 5.5.0
  • Gemma 4 detection via config.json (Gemma4ForConditionalGeneration architecture or model_type: gemma4) in addition to substring matching
  • New get_transformers_tier() API returns "550", "530", or "default"
  • Restrict trust_remote_code auto-enable to Nemotron models only — previously it was set to True for all unsloth/* transformers 5.x models (introduced in studio: improve onboarding UX, tooltips, and training defaults #4355, partially fixed for Gemma 4 in fix(studio): don't set trust_remote_code for Gemma 4 training #4795), which bypasses the compiler and disables fused cross-entropy. This fixed Qwen3.5-2b on colab T4. Credits to @mmathew23 for pointing this one out.

Resolves #4873

Test plan

  • ./install.sh --local creates both .venv_t5_530 and .venv_t5_550 with correct versions
  • 30 unit tests pass (test_transformers_version.py)
  • Qwen3.5 training on Colab T4
  • Gemma 4 training on Colab T4
  • Qwen3.5 training on B200
  • Gemma 4 training on B200

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@rolandtannous rolandtannous marked this pull request as draft April 6, 2026 19:08

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3400654afc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread studio/backend/core/inference/worker.py Outdated
Comment thread studio/backend/utils/transformers_version.py Outdated
@rolandtannous rolandtannous marked this pull request as ready for review April 6, 2026 23:19
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5445fa6e16

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread studio/backend/utils/models/model_config.py
Comment thread studio/setup.sh Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 45e3a02cc5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread studio/backend/utils/transformers_version.py
@rolandtannous rolandtannous merged commit f801e59 into main Apr 7, 2026
5 checks passed
@rolandtannous rolandtannous deleted the fix/transformers-v5-tiers branch April 7, 2026 16:05
@rolandtannous rolandtannous restored the fix/transformers-v5-tiers branch April 11, 2026 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Unsloth Studio UI: Dtype mismatch (float != c10::Half) during LoRA fine-tuning of gemma-4-E2B-it

1 participant