fix: keep napi property in package.json for napi-postinstall
#148
Conversation
WalkthroughThe changes increment the version of the project to 1.8.1 across Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant npm
participant package.json
participant napi-postinstall
Developer->>npm: npm install [email protected]
npm->>package.json: Read package.json
package.json->>napi-postinstall: Provide napi configuration
napi-postinstall-->>npm: Validate NAPI fields present
npm-->>Developer: Installation completes successfully
Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes found. Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
🧰 Additional context used🪛 markdownlint-cli2 (0.17.2)CHANGELOG.md18-18: Unordered list style (MD004, ul-style) ⏰ Context from checks skipped due to timeout of 90000ms (3)
🔇 Additional comments (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #148 +/- ##
=======================================
Coverage 92.17% 92.17%
=======================================
Files 13 13
Lines 3053 3053
=======================================
Hits 2814 2814
Misses 239 239 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JounQin
changed the title
napi property in package.json for napi-postinstallnapi property in package.json for napi-postinstall
CodSpeed Performance ReportMerging #148 will not alter performanceComparing Summary
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 7f6d229 in 58 minutes and 28 seconds. Click for details.
- Reviewed
75lines of code in4files - Skipped
0files when reviewing. - Skipped posting
4draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. package.json:46
- Draft comment:
Good: The reintroduction of the 'napi' property with its proper configuration (binaryName, packageName, wasm config, and targets) ensures compatibility with napi-postinstall. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. package.json:24
- Draft comment:
The postinstall script now references version 1.8.1, matching the updated package version. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
3. Cargo.toml:22
- Draft comment:
Version bump to 1.8.1 is consistent across Cargo.toml; this supports the npm package version. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
4. Cargo.lock:1240
- Draft comment:
Cargo.lock reflects the version update to 1.8.1; this is consistent with the new release. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_ukjBAklE52CeCG78
You can customize 
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 7f6d229 in 130 minutes and 18 seconds. Click for details.
- Reviewed
75lines of code in4files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. package.json:46
- Draft comment:
Good: The new 'napi' block (lines 46–73) is added with binaryName, packageName, wasm config, and targets. This satisfies the napi-postinstall requirements and should resolve the installation issue. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. package.json:24
- Draft comment:
Note: The 'postinstall' script now uses 'napi-postinstall unrs-resolver 1.8.1 check'. Ensure that all version numbers remain consistent. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
3. Cargo.toml:22
- Draft comment:
The package version is bumped to 1.8.1, matching the new release and npm 'postinstall' script version. This maintains consistency across the build. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_ukjBAklE52CeCG78
You can customize
close #147
Summary by CodeRabbit
Bug Fixes
napiproperty in the installation process to support post-install scripts.Chores
Important
Fix bug by retaining
napiproperty inpackage.jsonand update version to1.8.1.napiproperty inpackage.jsonfornapi-postinstallscript.1.8.1inCargo.toml,Cargo.lock, andpackage.json.This description was created by
for 7f6d229. You can customize this summary. It will automatically update as commits are pushed.