-
-
Notifications
You must be signed in to change notification settings - Fork 5
chore: release v1.8.0 #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2aa2489 to
8b7a02d
Compare
WalkthroughThis update increments the project version to 1.8.0 across multiple configuration files and documents the release in the changelog. The changelog entry highlights a runtime fallback feature for webcontainer, a merge from the upstream resolver repository, and credits contributors. No changes to code, functionality, or public interfaces are included. Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. πͺ§ TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #145 +/- ##
=======================================
Coverage 92.17% 92.17%
=======================================
Files 13 13
Lines 3053 3053
=======================================
Hits 2814 2814
Misses 239 239 β View full report in Codecov by Sentry. π New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! π
Reviewed everything up to 2aa2489 in 1 minute and 34 seconds. Click for details.
- Reviewed
47lines of code in3files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with π or π to teach Ellipsis.
1. Cargo.toml:12
- Draft comment:
Avoid using leading slashes in the include paths. Use relative paths (e.g., "src", "examples", "benches") to ensure proper packaging. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_Yz7pshsqA9xZyxx4
You can customize by changing your verbosity settings, reacting with π or π, replying to comments, or adding code review rules.
CodSpeed Performance ReportMerging #145 will not alter performanceComparing Summary
|
95a9fdf to
8b2142a
Compare
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! π
Reviewed 8b2142a in 1 minute and 2 seconds. Click for details.
- Reviewed
69lines of code in4files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with π or π to teach Ellipsis.
1. CHANGELOG.md:10
- Draft comment:
Changelog entry for v1.8.0 is clear and well formatted. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. Cargo.toml:6
- Draft comment:
Version bump to 1.8.0 and associated metadata (authors, repository, docs, release profile) are correctly updated. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
3. package.json:3
- Draft comment:
package.json version and postinstall script have been correctly updated to 1.8.0; configuration for NAPI targets and other metadata looks consistent. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_3XUEme1p8sZ8zvnB
You can customize by changing your verbosity settings, reacting with π or π, replying to comments, or adding code review rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
π§Ή Nitpick comments (1)
CHANGELOG.md (1)
18-19: Consistent list style
The contributors list uses*, but other lists use-. Consider converting these to-for uniform markdown style.π§° Tools
πͺ markdownlint-cli2 (0.17.2)
18-18: Unordered list style
Expected: dash; Actual: asterisk(MD004, ul-style)
19-19: Unordered list style
Expected: dash; Actual: asterisk(MD004, ul-style)
π Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
β Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
π Files selected for processing (3)
CHANGELOG.md(1 hunks)Cargo.toml(1 hunks)package.json(2 hunks)
π§° Additional context used
πͺ markdownlint-cli2 (0.17.2)
CHANGELOG.md
18-18: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
19-19: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
β° Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: Upload coverage file
- GitHub Check: Benchmark
- GitHub Check: Test wasi target
- GitHub Check: Test (windows-latest)
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: Analyze (javascript-typescript)
π Additional comments (4)
Cargo.toml (1)
7-7: Confirm version bump
The package version has been correctly updated to1.8.0, aligning with the intended release.package.json (2)
3-3: Confirm version bump
Theversionfield is now1.8.0, matching Cargo.toml and the changelog.
24-24: Update postinstall script version
Thepostinstallscript has been updated tonapi-postinstall unrs-resolver 1.8.0 check, correctly reflecting the new package version.CHANGELOG.md (1)
10-14: Approve changelog entry
The v1.8.0 release entry (2025-06-10) accurately documents the new feature and links to PR #144.
8b2142a to
a9314b5
Compare
a9314b5 to
52ce8f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
π§Ή Nitpick comments (1)
CHANGELOG.md (1)
22-23: Use consistent bullet style in contributor list.Bullet points for contributors use asterisks, but the rest of the changelog uses dashes. Update to dashes to satisfy markdownlint (MD004).
- * @JounQin - * @renovate[bot] + - @JounQin + - @renovate[bot]π§° Tools
πͺ markdownlint-cli2 (0.17.2)
22-22: Unordered list style
Expected: dash; Actual: asterisk(MD004, ul-style)
23-23: Unordered list style
Expected: dash; Actual: asterisk(MD004, ul-style)
π Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
β Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
π Files selected for processing (3)
CHANGELOG.md(1 hunks)Cargo.toml(1 hunks)package.json(2 hunks)
β Files skipped from review due to trivial changes (1)
- Cargo.toml
π§ Files skipped from review as they are similar to previous changes (1)
- package.json
π§° Additional context used
πͺ markdownlint-cli2 (0.17.2)
CHANGELOG.md
22-22: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
23-23: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
β° Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: Analyze (javascript-typescript)
π Additional comments (4)
CHANGELOG.md (4)
10-11: Changelog entry for v2.0.0 is accurate.Release header with comparison link and date is correctly formatted.
12-15: Feature section documented correctly.The new runtime fallback capability for webcontainer is clearly described and linked.
16-19: Chore section updated appropriately.Dependency update via renovate bot is properly logged.
20-21: Contributors section header present.The Contributors heading is added to list the authors for this release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! π
Reviewed 52ce8f3 in 2 minutes and 4 seconds. Click for details.
- Reviewed
78lines of code in4files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with π or π to teach Ellipsis.
1. Cargo.toml:10
- Draft comment:
The include paths use leading slashes (e.g. "/src") which may be treated as absolute paths. They are usually relative (e.g. "src", "examples", "benches"). - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
2. package.json:24
- Draft comment:
The postinstall script now correctly uses version 2.0.0. Verify this matches your release version. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_mO9nvc58uFYiflJ1
You can customize by changing your verbosity settings, reacting with π or π, replying to comments, or adding code review rules.
c0e4232 to
bc7a60b
Compare
|
|
@coderabbitai full review |
β Actions performedFull review triggered. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! π
Reviewed bc7a60b in 4 minutes and 35 seconds. Click for details.
- Reviewed
70lines of code in4files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with π or π to teach Ellipsis.
1. Cargo.toml:22
- Draft comment:
Version bump to 1.8.0 is applied consistently in this file. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative and does not provide any actionable feedback or suggestions. It simply states that a version bump is applied consistently, which does not align with the rules for useful comments.
2. package.json:3
- Draft comment:
package.json version and postinstall script have been updated to 1.8.0 and are in sync. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, as it only states that the package.json version and postinstall script have been updated and are in sync. It does not provide any actionable feedback or suggestions for improvement.
3. Cargo.lock:1241
- Draft comment:
Cargo.lock correctly reflects unrs_resolver at version 1.8.0. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, stating that a file correctly reflects a version of a dependency. It does not provide any actionable feedback or suggestions for improvement.
Workflow ID: wflow_vovo7u6as7qHOOrz
You can customize by changing your verbosity settings, reacting with π or π, replying to comments, or adding code review rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
π§Ή Nitpick comments (1)
CHANGELOG.md (1)
23-24: Use consistent list style.
The contributors list uses*for bullets but the projectβs style prefers-.- * @JounQin - * @renovate[bot] + - @JounQin + - @renovate[bot]π§° Tools
πͺ markdownlint-cli2 (0.17.2)
23-23: Unordered list style
Expected: dash; Actual: asterisk(MD004, ul-style)
24-24: Unordered list style
Expected: dash; Actual: asterisk(MD004, ul-style)
π Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
β Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
π Files selected for processing (3)
CHANGELOG.md(1 hunks)Cargo.toml(1 hunks)package.json(2 hunks)
π§° Additional context used
πͺ markdownlint-cli2 (0.17.2)
CHANGELOG.md
23-23: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
24-24: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
β° Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Codacy Static Code Analysis
π Additional comments (6)
package.json (2)
3-3: Approve version bump.
The"version"field has been correctly updated to1.8.0.
24-24: Approve postinstall script update.
The"postinstall"script now references1.8.0, matching the package version.CHANGELOG.md (1)
10-16: Approve new release entry.
The heading, date, and feature list for version1.8.0are correctly added and formatted.Cargo.toml (3)
19-19: Approve workspace dependency version bump.
The workspace dependency forunrs_resolverhas been updated to1.8.0.
23-23: Approve package version bump.
The crateβsversionfield is correctly set to1.8.0.
19-23:β Verification successful
Ensure
Cargo.lockis updated.
The version changes inCargo.tomlrequire a corresponding update toCargo.lock. Please commit the updated lock file to avoid version mismatches.
π Script executed:
#!/bin/bash # Search for any lingering old versions in Cargo.lock rg -n '1\.7\.13' Cargo.lock || echo "No references to 1.7.13 found."Length of output: 100
π Script executed:
#!/bin/bash # Confirm updated version of unrs_resolver in Cargo.lock rg -n 'name = "unrs_resolver"' -A1 Cargo.lock || echo "unrs_resolver not found in Cargo.lock"Length of output: 98
Cargo.lock is Up-to-Date
Confirmed that
unrs_resolveris listed at version1.8.0inCargo.lockand there are no lingering references to the previous1.7.13version. No further changes are needed here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! π
Reviewed 9065adc in 14 minutes and 7 seconds. Click for details.
- Reviewed
57lines of code in3files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with π or π to teach Ellipsis.
1. CHANGELOG.md:10
- Draft comment:
Version inconsistency: changelog now shows 1.8.0 but release notes and breaking changes imply a 2.0.0 bump. - Reason this comment was not posted:
Comment looked like it was already resolved.
2. Cargo.toml:23
- Draft comment:
Version in Cargo.toml is set to 1.8.0 despite documented API breaking changes that suggest a major (2.0.0) release. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50% While downgrading from 2.0.0 to 1.8.0 might seem unusual, I don't have any evidence of the "documented API breaking changes" the comment refers to. The comment makes an assertion without providing proof. Following semver, going from 2.0.0 to 1.8.0 would be unusual, but without seeing the actual API changes or documentation, I can't verify this claim. I might be too strict in requiring evidence - perhaps the reviewer has access to documentation or commit history that shows the breaking changes that I can't see. Even if there are breaking changes documented elsewhere, a version change requires careful consideration of the full context. Without that context in the PR, this comment isn't actionable enough. The comment should be deleted as it makes claims about API breaking changes without providing evidence within the context of the PR review.
3. package.json:3
- Draft comment:
Ensure version consistency: package.json uses 1.8.0 while release details mention v2.0.0 with breaking changes. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50% The author deliberately changed the version from 2.0.0 to 1.8.0 in multiple places, suggesting this was intentional. Without seeing the release details mentioned in the comment, I can't verify if there's actually an inconsistency. Version changes could be for many valid reasons like rolling back a release or fixing a versioning mistake. The comment might be correct - there could be release notes or git tags showing 2.0.0 is the correct version. The deliberate change in multiple places could be a mistake. Without seeing the release details mentioned, we don't have strong evidence that this is incorrect. The systematic change in multiple places suggests intentionality. Delete this comment as we don't have strong evidence of an issue, and version changes are often intentional for valid reasons.
Workflow ID: wflow_BpREyWF0ZIeR8rVL
You can customize by changing your verbosity settings, reacting with π or π, replying to comments, or adding code review rules.



π€ New release
unrs_resolver: 1.7.13 -> 1.8.0 (β API breaking changes)β
unrs_resolverbreaking changesChangelog
This PR was generated with release-plz.
Important
Release version 1.8.0 of
unrs_resolverwith updated dependencies and documentation.unrs_resolverversion to 1.8.0 inCargo.toml,Cargo.lock, andpackage.json.postinstallscript inpackage.jsonto use version 1.8.0.This description was created by
for bc7a60b. You can customize this summary. It will automatically update as commits are pushed.
Summary by CodeRabbit