Skip to content

Conversation

@JounQin
Copy link
Member

@JounQin JounQin commented May 27, 2025

πŸ€– New release

  • unrs_resolver: 1.7.2 -> 1.7.3 (βœ“ API compatible changes)
Changelog

Bug Fixes

  • custom condition_names should take higher priority than target in package.json (#115)


This PR was generated with release-plz.


Important

Bump unrs_resolver to v1.7.3 with a bug fix for condition_names priority in package.json.

  • Version Bump:
    • Update unrs_resolver version from 1.7.2 to 1.7.3 in Cargo.toml, Cargo.lock, and npm/package.json.
  • Bug Fix:
    • Fix priority of custom condition_names over target in package.json as noted in CHANGELOG.md.
  • Changelog:
    • Add entry for version 1.7.3 in CHANGELOG.md documenting the bug fix.

This description was created by Ellipsis for e1c1b43. You can customize this summary. It will automatically update as commits are pushed.

Summary by CodeRabbit

  • Documentation

    • Updated the changelog with a new entry for version 1.7.3, highlighting a bug fix related to priority of custom condition names in package configuration.
  • Chores

    • Bumped package versions to 1.7.3 in relevant files.
    • Updated post-install script to use the new version number.

@JounQin JounQin force-pushed the release-plz-2025-05-27T15-56-37Z branch from a0330be to bb1aaea Compare May 27, 2025 15:56
@coderabbitai
Copy link

coderabbitai bot commented May 27, 2025

Walkthrough

The package version for "unrs_resolver" was incremented from 1.7.2 to 1.7.3 in both the Cargo.toml and npm/package.json files. The postinstall script in package.json was also updated to reference the new version. Additionally, a changelog entry was added documenting a bug fix prioritizing custom condition_names over the target field. No other code or dependency changes were made.

Changes

Files Change Summary
Cargo.toml Bumped version from 1.7.2 to 1.7.3
npm/package.json Bumped version from 1.7.2 to 1.7.3; updated postinstall script
CHANGELOG.md Added changelog entry for version 1.7.3 with a bug fix (#115)

Suggested labels

release

Poem

The numbers climb, a hop, a leap,
From 1.7.2 to .3 we sweep!
A fix to guide conditions right,
Priorities now in clear sight.
πŸ‡βœ¨
No code to tweak, just logs to share,
A little hop with utmost care!


πŸ“œ Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between bb1aaea and e1c1b43.

β›” Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
πŸ“’ Files selected for processing (3)
  • CHANGELOG.md (1 hunks)
  • Cargo.toml (1 hunks)
  • npm/package.json (2 hunks)
βœ… Files skipped from review due to trivial changes (2)
  • Cargo.toml
  • CHANGELOG.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • npm/package.json
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Codacy Static Code Analysis
  • GitHub Check: Test (windows-latest)
  • GitHub Check: Benchmark

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share
πŸͺ§ Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! πŸ‘

Reviewed everything up to a0330be in 53 seconds. Click for details.
  • Reviewed 26 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with πŸ‘ or πŸ‘Ž to teach Ellipsis.
1. Cargo.lock:1177
  • Draft comment:
    Version bump updated to 1.7.3; ensure all dependencies remain compatible.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
2. Cargo.toml:7
  • Draft comment:
    Version field updated to 1.7.3; verify it matches Cargo.lock.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
3. Cargo.toml:12
  • Draft comment:
    Consider removing leading slashes in the 'include' paths (use 'src', 'examples', 'benches').
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_8wYVxk5nun89DLYl

You can customize Ellipsis by changing your verbosity settings, reacting with πŸ‘ or πŸ‘Ž, replying to comments, or adding code review rules.

@codecov
Copy link

codecov bot commented May 27, 2025

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 93.41%. Comparing base (1e51e82) to head (e1c1b43).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #114   +/-   ##
=======================================
  Coverage   93.41%   93.41%           
=======================================
  Files          13       13           
  Lines        2870     2870           
=======================================
  Hits         2681     2681           
  Misses        189      189           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
Cargo.toml (1)

7-7: Consider adding a CHANGELOG entry – I don’t see a corresponding update to CHANGELOG.md or release notes for v1.7.3. If your project maintains a changelog, please ensure release-plz has generated the entry, or add it manually.

πŸ“œ Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 4b5f796 and bb1aaea.

β›” Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
πŸ“’ Files selected for processing (2)
  • Cargo.toml (1 hunks)
  • npm/package.json (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Test (windows-latest)
  • GitHub Check: Benchmark
  • GitHub Check: Codacy Static Code Analysis
πŸ”‡ Additional comments (4)
Cargo.toml (1)

7-7: Bump crate version to 1.7.3 – This version update aligns the unrs_resolver crate with the new release and matches the change in npm/package.json.

npm/package.json (3)

3-3: Update npm package version to 1.7.3 – This keeps the npm package in sync with the Cargo.toml bump.


3-3: Ensure lockfile is updated – After bumping the version, please regenerate and commit your package-lock.json or yarn.lock to keep dependencies in sync.


19-19: Update postinstall script to v1.7.3 – The postinstall command now correctly references the new release version.

@codspeed-hq
Copy link

codspeed-hq bot commented May 27, 2025

CodSpeed Performance Report

Merging #114 will not alter performance

Comparing release-plz-2025-05-27T15-56-37Z (e1c1b43) with main (1e51e82)

Summary

βœ… 3 untouched benchmarks

@JounQin JounQin force-pushed the release-plz-2025-05-27T15-56-37Z branch from bb1aaea to 30330d9 Compare May 28, 2025 05:34
@JounQin JounQin force-pushed the release-plz-2025-05-27T15-56-37Z branch from 30330d9 to e1c1b43 Compare May 28, 2025 05:34
@sonarqubecloud
Copy link

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! πŸ‘

Reviewed e1c1b43 in 49 seconds. Click for details.
  • Reviewed 64 lines of code in 4 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with πŸ‘ or πŸ‘Ž to teach Ellipsis.
1. Cargo.toml:12
  • Draft comment:
    Consider using relative paths (e.g. "src", "examples", "benches") rather than paths with a leading '/' in the include list.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
2. npm/package.json:3
  • Draft comment:
    Version bump and postinstall script update to 1.7.3 are consistent with the release.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative and does not provide any actionable feedback or suggestions. It simply states that the version bump and postinstall script update are consistent with the release, which is not necessary for the PR author to know.

Workflow ID: wflow_cQh9uD0wl9chYthR

You can customize Ellipsis by changing your verbosity settings, reacting with πŸ‘ or πŸ‘Ž, replying to comments, or adding code review rules.

@JounQin JounQin merged commit b782e89 into main May 28, 2025
23 checks passed
@JounQin JounQin deleted the release-plz-2025-05-27T15-56-37Z branch May 28, 2025 05:36
@coderabbitai coderabbitai bot mentioned this pull request Jul 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants