-
-
Notifications
You must be signed in to change notification settings - Fork 5
chore: release v1.7.3 #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a0330be to
bb1aaea
Compare
WalkthroughThe package version for "unrs_resolver" was incremented from 1.7.2 to 1.7.3 in both the Cargo.toml and npm/package.json files. The postinstall script in package.json was also updated to reference the new version. Additionally, a changelog entry was added documenting a bug fix prioritizing custom Changes
Suggested labels
Poem
π Recent review detailsConfiguration used: CodeRabbit UI β Files ignored due to path filters (1)
π Files selected for processing (3)
β Files skipped from review due to trivial changes (2)
π§ Files skipped from review as they are similar to previous changes (1)
β° Context from checks skipped due to timeout of 90000ms (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. πͺ§ TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! π
Reviewed everything up to a0330be in 53 seconds. Click for details.
- Reviewed
26lines of code in2files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with π or π to teach Ellipsis.
1. Cargo.lock:1177
- Draft comment:
Version bump updated to 1.7.3; ensure all dependencies remain compatible. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. Cargo.toml:7
- Draft comment:
Version field updated to 1.7.3; verify it matches Cargo.lock. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
3. Cargo.toml:12
- Draft comment:
Consider removing leading slashes in the 'include' paths (use 'src', 'examples', 'benches'). - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_8wYVxk5nun89DLYl
You can customize by changing your verbosity settings, reacting with π or π, replying to comments, or adding code review rules.
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
=======================================
Coverage 93.41% 93.41%
=======================================
Files 13 13
Lines 2870 2870
=======================================
Hits 2681 2681
Misses 189 189 β View full report in Codecov by Sentry. π New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
π§Ή Nitpick comments (1)
Cargo.toml (1)
7-7: Consider adding a CHANGELOG entry β I donβt see a corresponding update toCHANGELOG.mdor release notes for v1.7.3. If your project maintains a changelog, please ensure release-plz has generated the entry, or add it manually.
π Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
β Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
π Files selected for processing (2)
Cargo.toml(1 hunks)npm/package.json(2 hunks)
β° Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Test (windows-latest)
- GitHub Check: Benchmark
- GitHub Check: Codacy Static Code Analysis
π Additional comments (4)
Cargo.toml (1)
7-7: Bump crate version to 1.7.3 β This version update aligns theunrs_resolvercrate with the new release and matches the change innpm/package.json.npm/package.json (3)
3-3: Update npm package version to 1.7.3 β This keeps the npm package in sync with the Cargo.toml bump.
3-3: Ensure lockfile is updated β After bumping the version, please regenerate and commit yourpackage-lock.jsonoryarn.lockto keep dependencies in sync.
19-19: Update postinstall script to v1.7.3 β Thepostinstallcommand now correctly references the new release version.
CodSpeed Performance ReportMerging #114 will not alter performanceComparing Summary
|
bb1aaea to
30330d9
Compare
30330d9 to
e1c1b43
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! π
Reviewed e1c1b43 in 49 seconds. Click for details.
- Reviewed
64lines of code in4files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with π or π to teach Ellipsis.
1. Cargo.toml:12
- Draft comment:
Consider using relative paths (e.g. "src", "examples", "benches") rather than paths with a leading '/' in the include list. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
2. npm/package.json:3
- Draft comment:
Version bump and postinstall script update to 1.7.3 are consistent with the release. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative and does not provide any actionable feedback or suggestions. It simply states that the version bump and postinstall script update are consistent with the release, which is not necessary for the PR author to know.
Workflow ID: wflow_cQh9uD0wl9chYthR
You can customize by changing your verbosity settings, reacting with π or π, replying to comments, or adding code review rules.



π€ New release
unrs_resolver: 1.7.2 -> 1.7.3 (β API compatible changes)Changelog
Bug Fixes
condition_namesshould take higher priority than target in package.json (#115)This PR was generated with release-plz.
Important
Bump
unrs_resolverto v1.7.3 with a bug fix forcondition_namespriority inpackage.json.unrs_resolverversion from 1.7.2 to 1.7.3 inCargo.toml,Cargo.lock, andnpm/package.json.condition_namesover target inpackage.jsonas noted inCHANGELOG.md.CHANGELOG.mddocumenting the bug fix.This description was created by
for e1c1b43. You can customize this summary. It will automatically update as commits are pushed.
Summary by CodeRabbit
Documentation
Chores