Skip to content

Conversation

@JounQin
Copy link
Member

@JounQin JounQin commented Apr 25, 2025

πŸ€– New release

  • unrs_resolver: 1.7.0 -> 1.7.1 (βœ“ API compatible changes)
Changelog

Chore

  • bump napi-postinstall to support yarn/pnpm on webcontainer (#103)

Testing


This PR was generated with release-plz.


Important

Bump unrs_resolver version to 1.7.1 with a new test case for issue #65 and update version references in configuration files.

This description was created by Ellipsis for 2e2a12a. You can customize this summary. It will automatically update as commits are pushed.

Summary by CodeRabbit

@JounQin JounQin force-pushed the release-plz-2025-04-25T14-49-27Z branch from 9537368 to 2ffbade Compare April 25, 2025 14:49
@coderabbitai
Copy link

coderabbitai bot commented Apr 25, 2025

Walkthrough

This update increments the version number of the unrs_resolver package from 1.7.0 to 1.7.1 in both the Cargo.toml and npm package.json files. Additionally, a new entry is added to the changelog, documenting the bump of the napi-postinstall dependency to support yarn and pnpm in the webcontainer environment and the inclusion of a test case related to issue #65. The postinstall script was also updated to reflect the new version. No changes were made to the codebase or exported entities.

Changes

File(s) Change Summary
CHANGELOG.md Added a new entry for version 1.7.1 documenting the napi-postinstall dependency bump for yarn and pnpm support and a test case related to issue #65 (PRs #103, #100).
Cargo.toml Updated package version from 1.7.0 to 1.7.1.
npm/package.json Updated package version from 1.7.0 to 1.7.1 and updated postinstall script to reflect the new version.

Possibly related PRs

  • unrs/unrs-resolver#68: Previous version bump and changelog update, related as a sequential release.
  • unrs/unrs-resolver#103: Introduced the napi-postinstall dependency bump and postinstall script changes referenced by this PR.
  • unrs/unrs-resolver#99: Earlier version bump and changelog update related to the release process.

Suggested labels

enhancement

Poem

A hop and a skip, the version’s anew,
1.7.1, we welcome you!
With changelog lines both neat and bright,
And tests that make our future right.
No code was changed, but still we cheerβ€”
For every small hop brings progress near!
πŸ‡βœ¨


πŸ“œ Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 2e2a12a and 4c06352.

πŸ“’ Files selected for processing (1)
  • CHANGELOG.md (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Test (windows-latest)
  • GitHub Check: Benchmark

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share
πŸͺ§ Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! πŸ‘

Reviewed everything up to 9537368 in 1 minute and 1 seconds. Click for details.
  • Reviewed 43 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 6 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with πŸ‘ or πŸ‘Ž to teach Ellipsis.
1. Cargo.toml:7
  • Draft comment:
    Version updated to 1.7.1; please confirm consistency with changelog.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
2. Cargo.lock:1175
  • Draft comment:
    Dependency unrs_resolver bumped to 1.7.1; looks correct.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
3. Cargo.toml:12
  • Draft comment:
    The include paths are specified with a leading '/' which may be interpreted as absolute paths. Consider using relative paths (e.g. "src" instead of "/src") to ensure the correct package contents.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
4. Cargo.toml:91
  • Draft comment:
    Verify if using the syntax 'dep:serde' in the features section is intentional. Typically, optional dependencies are enabled by listing their names (e.g. "serde") directly. Confirm that this syntax works as expected.
  • Reason this comment was not posted:
    Confidence changes required: 50% <= threshold 50% None
5. CHANGELOG.md:97
  • Draft comment:
    There's a typo in the word 'pacakge.json' on line 97. It should be 'package.json'.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
6. CHANGELOG.md:187
  • Draft comment:
    There is an inconsistency in the repository identifier used in the version comparison URLs. For example, line 187 uses 'unrspack-resolver' and 'unrs_resolver', whereas the repository is named 'unrs-resolver'. Consider standardizing the naming to avoid confusion.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_6Yh3I2zWRg4dLDNt

You can customize Ellipsis by changing your verbosity settings, reacting with πŸ‘ or πŸ‘Ž, replying to comments, or adding code review rules.

@codecov
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 93.40%. Comparing base (ce6bc1c) to head (4c06352).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #102   +/-   ##
=======================================
  Coverage   93.40%   93.40%           
=======================================
  Files          13       13           
  Lines        2865     2865           
=======================================
  Hits         2676     2676           
  Misses        189      189           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 25, 2025

CodSpeed Performance Report

Merging #102 will not alter performance

Comparing release-plz-2025-04-25T14-49-27Z (4c06352) with main (ce6bc1c)

Summary

βœ… 3 untouched benchmarks

@JounQin JounQin force-pushed the release-plz-2025-04-25T14-49-27Z branch from 2ffbade to 41ae07d Compare April 26, 2025 14:39
@JounQin JounQin force-pushed the release-plz-2025-04-25T14-49-27Z branch from 41ae07d to 2e2a12a Compare April 26, 2025 14:39
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! πŸ‘

Reviewed 2e2a12a in 1 minute and 0 seconds. Click for details.
  • Reviewed 64 lines of code in 4 files
  • Skipped 0 files when reviewing.
  • Skipped posting 9 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with πŸ‘ or πŸ‘Ž to teach Ellipsis.
1. Cargo.toml:7
  • Draft comment:
    Version bump to 1.7.1 looks consistent.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
2. npm/package.json:3
  • Draft comment:
    npm package version updated to 1.7.1.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
3. npm/package.json:19
  • Draft comment:
    Postinstall script updated to use version 1.7.1.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
4. Cargo.toml:7
  • Draft comment:
    Version updated to 1.7.1 in Cargo.toml – looks consistent.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
5. npm/package.json:3
  • Draft comment:
    npm package version bumped to 1.7.1.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
6. npm/package.json:19
  • Draft comment:
    Postinstall script now reflects version 1.7.1.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
7. CHANGELOG.md:95
  • Draft comment:
    Typo: 'pacakge.json' should be corrected to 'package.json'.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
8. CHANGELOG.md:480
  • Draft comment:
    Typo: The entry '* (napi) release wasi build' should be corrected to '* (napi) release wasi build' (ensure proper closing of the italicized content).
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
9. Cargo.lock:1
  • Draft comment:
    Typo detected: In the header comment on line 1, the phrase "automatically @generated" likely should be "automatically generated" without the '@' symbol.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_Xqe7QcB3j4YZ07Tz

You can customize Ellipsis by changing your verbosity settings, reacting with πŸ‘ or πŸ‘Ž, replying to comments, or adding code review rules.

@sonarqubecloud
Copy link

@JounQin JounQin merged commit 1873179 into main Apr 26, 2025
23 checks passed
@JounQin JounQin deleted the release-plz-2025-04-25T14-49-27Z branch April 26, 2025 14:47
This was referenced May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants