Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: webpack and esbuild query string support #144

Merged
merged 10 commits into from
Jul 26, 2022

Conversation

Demivan
Copy link
Contributor

@Demivan Demivan commented Jul 25, 2022

Fixes #142

@Demivan
Copy link
Contributor Author

Demivan commented Jul 25, 2022

Would be nice if someone can verify this. Locally I get issue with some modules being transformed twice (vue custom blocks).

@Demivan
Copy link
Contributor Author

Demivan commented Aug 3, 2022

Tried hacking using nuxt/bridge repo.

Discovered that ident will not work. Webpack 4 only uses ident if use is an array, not a function.
But using inline options as suggested in webpack/webpack#8406 does not work either - loader is not being called for some reason. Investigating why.

@Demivan
Copy link
Contributor Author

Demivan commented Aug 3, 2022

@antfu Found solution. PR incoming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query string is not included with id in transformInclude when using webpack
2 participants