Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: persist generated https certificates #132

Open
1 task
danielwaltz opened this issue Oct 20, 2023 · 1 comment · May be fixed by #136
Open
1 task

feat: persist generated https certificates #132

danielwaltz opened this issue Oct 20, 2023 · 1 comment · May be fixed by #136
Labels
enhancement New feature or request

Comments

@danielwaltz
Copy link

Describe the feature

When using self-signed generated certificates for local development, every time you restart listhen (or in my case restart the nuxt dev server), a new certificate is generated and your browser's "Your connection is not private" page must be explicitly bypassed.

As a small optimization, it would be very nice if the generated certificates were (maybe optionally) persisted to disk so that you only need to manually bypass the browser's insecure warning page once (or each time a new certificate is generated). This is similar to how @vitejs/plugin-basic-ssl works by saving the cert inside of a hidden temp dir in your project's node_modules directory (./node_modules/.vite/basic-ssl).

I could see listhen doing something similar by persisting the certs at ./node_modules/.listhen/certs.

I'm not sure if this has security implications or may be unreliable depending on the runtime environment, so if this is impractical and/or unadvisable I completely understand. Thanks!

Additional information

  • Would you be willing to help implement this feature?
@pi0 pi0 added the enhancement New feature or request label Oct 21, 2023
@pi0
Copy link
Member

pi0 commented Oct 21, 2023

Thanks for the idea! The default behavior of not persisting was kinda intentional to make sure warn users everytime about this and avoid possible local cert leaking problems but at least via an opt-in flag/option i think we can implement this feature 💯

@Mastercuber Mastercuber linked a pull request Nov 5, 2023 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants