Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: skip nullish values from source #29

Merged
merged 4 commits into from
May 12, 2021
Merged

feat!: skip nullish values from source #29

merged 4 commits into from
May 12, 2021

Conversation

pi0
Copy link
Member

@pi0 pi0 commented May 12, 2021

Before: defu({ a: undefined }, { a: 1 }) => { a: undefined }

After: defu({ a: undefined }, { a: 1 }) => { a: 1}

This is breaking behavior from being constant with defaults-deep

@pi0 pi0 changed the title feat: skip undefined feat!: skip undefined May 12, 2021
@pi0 pi0 changed the title feat!: skip undefined feat!: skip undefined values from source May 12, 2021
@pi0 pi0 changed the title feat!: skip undefined values from source feat!: skip nullish values from source May 12, 2021
@pi0 pi0 merged commit 076f10a into master May 12, 2021
@pi0 pi0 deleted the feat/skip-undefined branch May 12, 2021 16:42
bmulholland pushed a commit to nuxt-community/auth-module that referenced this pull request Dec 24, 2021
May affect some options that were set to undefined. See unjs/defu#29. I've done a manual check and I don't think anything we have in this repo is affected, but double check your auth config for any `undefined` values. If they exist, confirm they continue to work as expected.

Co-authored-by: Renovate Bot <[email protected]>
bmulholland pushed a commit to nuxt-community/auth-module that referenced this pull request Dec 24, 2021
May affect some options that were set to undefined. See unjs/defu#29. I've done a manual check and I don't think anything we have in this repo is affected, but double check your auth config for any `undefined` values. If they exist, confirm they continue to work as expected.

Co-authored-by: Renovate Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant