docs: update README and add JSDoc #212
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
reviewed
Dec 16, 2024
| @@ -104,81 +112,7 @@ c12 merged config sources with [unjs/defu](https://github.com/unjs/defu) by belo | |||
|
|
|||
| ## Options | |||
|
|
|||
| ### `cwd` | |||
There was a problem hiding this comment.
would maintaining JSDoc not more beneficial?
pi0
reviewed
Dec 16, 2024
| @@ -108,6 +113,11 @@ export async function loadConfig< | |||
| }); | |||
| } | |||
|
|
|||
| if (options.globalDefineConfigFn) { | |||
|
Thanks but please create separate PRs 🙏🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds
createDefineConfig, so we could close #84.Additionally, the last commit is an addition to improve DX (that I believe Nuxt core/Content3 and possibly TW/i18n modules can also benefit from) - but I'm OK to leave it out as well. (let me write a quick test for this btw)