Skip to content

Commit e625575

Browse files
Normalize tables and views list in MetadataManager.
Earlier in MetadataManager.listTables used QualifiedObjectName that had a check for lowercase. Now, we can normalize identifer based on the connector, until specified in the connector, it would by default normalized to lowercase.
1 parent 4891aaf commit e625575

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

presto-main-base/src/main/java/com/facebook/presto/metadata/MetadataManager.java

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -571,9 +571,11 @@ public List<QualifiedObjectName> listTables(Session session, QualifiedTablePrefi
571571
ConnectorSession connectorSession = session.toConnectorSession(connectorId);
572572
metadata.listTables(connectorSession, prefix.getSchemaName()).stream()
573573
.map(convertFromSchemaTableName(prefix.getCatalogName()))
574-
.filter(name -> prefix.matches(new QualifiedObjectName(name.getCatalogName(),
574+
.map(name -> new QualifiedObjectName(
575+
name.getCatalogName(),
575576
normalizeIdentifier(session, connectorId.getCatalogName(), name.getSchemaName()),
576-
normalizeIdentifier(session, connectorId.getCatalogName(), name.getObjectName()))))
577+
normalizeIdentifier(session, connectorId.getCatalogName(), name.getObjectName())))
578+
.filter(prefix::matches)
577579
.forEach(tables::add);
578580
}
579581
}
@@ -996,9 +998,11 @@ public List<QualifiedObjectName> listViews(Session session, QualifiedTablePrefix
996998
ConnectorSession connectorSession = session.toConnectorSession(connectorId);
997999
metadata.listViews(connectorSession, prefix.getSchemaName()).stream()
9981000
.map(convertFromSchemaTableName(prefix.getCatalogName()))
999-
.filter(name -> prefix.matches(new QualifiedObjectName(name.getCatalogName(),
1001+
.map(name -> new QualifiedObjectName(
1002+
name.getCatalogName(),
10001003
normalizeIdentifier(session, connectorId.getCatalogName(), name.getSchemaName()),
1001-
normalizeIdentifier(session, connectorId.getCatalogName(), name.getObjectName()))))
1004+
normalizeIdentifier(session, connectorId.getCatalogName(), name.getObjectName())))
1005+
.filter(prefix::matches)
10021006
.forEach(views::add);
10031007
}
10041008
}

0 commit comments

Comments
 (0)