[native] Enable Parquet and Spatial by default

The default build of PrestoC++ should enable Parquet and Spatial
support.
Both do not require separate adapters (unlike other features) and
dependencies are present in a default dependency installation.

Author: czentgr

.github/workflows/prestocpp-linux-adapters-build.yml

@@ -66,7 +66,6 @@ jobs:
             -DTREAT_WARNINGS_AS_ERRORS=1 \
             -DENABLE_ALL_WARNINGS=1 \
             -DCMAKE_BUILD_TYPE=Release \
-            -DPRESTO_ENABLE_PARQUET=ON \
             -DPRESTO_ENABLE_S3=ON \
             -DPRESTO_ENABLE_GCS=ON \
             -DPRESTO_ENABLE_ABFS=OFF \
@@ -76,7 +75,6 @@ jobs:
             -DPRESTO_STATS_REPORTER_TYPE=PROMETHEUS \
             -DPRESTO_MEMORY_CHECKER_TYPE=LINUX_MEMORY_CHECKER \
             -DPRESTO_ENABLE_TESTING=OFF \
-            -DPRESTO_ENABLE_SPATIAL=ON \
             -DCMAKE_PREFIX_PATH=/usr/local \
             -DThrift_ROOT=/usr/local \
             -DCMAKE_CXX_COMPILER_LAUNCHER=ccache \

.github/workflows/prestocpp-linux-build-and-unit-test.yml

@@ -86,12 +86,10 @@ jobs:
             -DTREAT_WARNINGS_AS_ERRORS=1 \
             -DENABLE_ALL_WARNINGS=1 \
             -DCMAKE_BUILD_TYPE=Release \
-            -DPRESTO_ENABLE_PARQUET=ON \
             -DPRESTO_ENABLE_REMOTE_FUNCTIONS=ON \
             -DPRESTO_ENABLE_JWT=ON \
             -DPRESTO_STATS_REPORTER_TYPE=PROMETHEUS \
             -DPRESTO_MEMORY_CHECKER_TYPE=LINUX_MEMORY_CHECKER \
-            -DPRESTO_ENABLE_SPATIAL=ON \
             -DCMAKE_PREFIX_PATH=/usr/local \
             -DThrift_ROOT=/usr/local \
             -DCMAKE_CXX_COMPILER_LAUNCHER=ccache \

.github/workflows/prestocpp-linux-build.yml

@@ -42,7 +42,6 @@ jobs:
           -DTREAT_WARNINGS_AS_ERRORS=1 \
           -DENABLE_ALL_WARNINGS=1 \
           -DCMAKE_BUILD_TYPE=Debug \
-          -DPRESTO_ENABLE_PARQUET=ON \
           -DPRESTO_ENABLE_S3=ON \
           -DPRESTO_ENABLE_GCS=ON \
           -DPRESTO_ENABLE_ABFS=OFF \
@@ -51,7 +50,6 @@ jobs:
           -DPRESTO_ENABLE_JWT=ON \
           -DPRESTO_STATS_REPORTER_TYPE=PROMETHEUS \
           -DPRESTO_MEMORY_CHECKER_TYPE=LINUX_MEMORY_CHECKER \
-          -DPRESTO_ENABLE_SPATIAL=ON \
           -DPRESTO_ENABLE_TESTING=OFF \
           -DCMAKE_PREFIX_PATH=/usr/local \
           -DThrift_ROOT=/usr/local \

presto-native-execution/CMakeLists.txt

@@ -54,7 +54,7 @@ option(PRESTO_ENABLE_GCS "Build GCS support" OFF)
 option(PRESTO_ENABLE_ABFS "Build ABFS support" OFF)
 
 # Forwards user input to VELOX_ENABLE_PARQUET.
-option(PRESTO_ENABLE_PARQUET "Enable Parquet support" OFF)
+option(PRESTO_ENABLE_PARQUET "Enable Parquet support" ON)
 
 # Forwards user input to VELOX_ENABLE_CUDF.
 option(PRESTO_ENABLE_CUDF "Enable cuDF support" OFF)
@@ -70,7 +70,7 @@ option(PRESTO_ENABLE_JWT "Enable JWT (JSON Web Token) authentication" OFF)
 
 option(PRESTO_ENABLE_ARROW_FLIGHT_CONNECTOR "Enable Arrow Flight connector" OFF)
 
-option(PRESTO_ENABLE_SPATIAL "Enable spatial support" OFF)
+option(PRESTO_ENABLE_SPATIAL "Enable spatial support" ON)
 
 # Set all Velox options below and make sure that if we include folly headers or
 # other dependency headers that include folly headers we turn off the coroutines

presto-native-execution/README.md

@@ -81,8 +81,15 @@ Compilers (and versions) not mentioned are known to not work or have not been tr
 
 ### Build Prestissimo
 #### Parquet and S3 Support
-To enable Parquet and S3 support, set `PRESTO_ENABLE_PARQUET = "ON"`,
-`PRESTO_ENABLE_S3 = "ON"` in the environment.
+Parquet support is enabled by default. To disable it, add `-DPRESTO_ENABLE_PARQUET=OFF`
+to the `EXTRA_CMAKE_FLAGS` environment variable.
+
+`export EXTRA_CMAKE_FLAGS="${EXTRA_CMAKE_FLAGS -DPRESTO_ENABLE_PARQUET=OFF"`
+
+To enable S3 support, add `-DPRESTO_ENABLE_S3=ON` to the `EXTRA_CMAKE_FLAGS`
+environment variable.
+
+`export EXTRA_CMAKE_FLAGS="${EXTRA_CMAKE_FLAGS} -DPRESTO_ENABLE_S3=ON"`
 
 S3 support needs the [AWS SDK C++](https://github.com/aws/aws-sdk-cpp) library.
 This dependency can be installed by running the target platform build script
@@ -91,8 +98,10 @@ from the `presto/presto-native-execution` directory.
 `./velox/scripts/setup-centos9.sh install_aws`
 
 #### JWT Authentication
-To enable JWT authentication support, set `PRESTO_ENABLE_JWT = "ON"` in
-the environment.
+To enable JWT authentication support, add `-DPRESTO_ENABLE_JWT=ON` to the
+`EXTRA_CMAKE_FLAGS` environment variable.
+
+`export EXTRA_CMAKE_FLAGS="${EXTRA_CMAKE_FLAGS} -DPRESTO_ENABLE_JWT=ON"`
 
 JWT authentication support needs the [JWT CPP](https://github.com/Thalhammer/jwt-cpp) library.
 This dependency can be installed by running the script below from the
@@ -109,6 +118,8 @@ follow these steps:
 
 *CMake flags:* `PRESTO_STATS_REPORTER_TYPE=PROMETHEUS`
 
+`export EXTRA_CMAKE_FLAGS="${EXTRA_CMAKE_FLAGS} -DPRESTO_STATS_REPORTER_TYPE=PROMETHEUS"`
+
 *Runtime configuration:* `runtime-metrics-collection-enabled=true`
 
 * After installing the above dependencies, from the
@@ -117,8 +128,8 @@ follow these steps:
 * Use `make unittest` to build and run tests.
 
 #### Arrow Flight Connector
-To enable Arrow Flight connector support, add to the extra cmake flags:
-`EXTRA_CMAKE_FLAGS = -DPRESTO_ENABLE_ARROW_FLIGHT_CONNECTOR=ON`
+To enable Arrow Flight connector support, add to the `EXTRA_CMAKE_FLAGS` environment variable:
+`export EXTRA_CMAKE_FLAGS="${EXTRA_CMAKE_FLAGS} -DPRESTO_ENABLE_ARROW_FLIGHT_CONNECTOR=ON"`
 
 The Arrow Flight connector requires the Arrow Flight library. You can install this dependency
 by running the following script from the `presto/presto-native-execution` directory:
@@ -128,8 +139,8 @@ by running the following script from the `presto/presto-native-execution` direct
 #### Nvidia cuDF GPU Support
 
 To enable support with [cuDF](https://github.com/facebookincubator/velox/tree/main/velox/experimental/cudf),
-add to the extra cmake flags:
-`EXTRA_CMAKE_FLAGS = -DPRESTO_ENABLE_CUDF=ON`
+add to the `EXTRA_CMAKE_FLAGS` environment variable:
+`export EXTRA_CMAKE_FLAGS="${EXTRA_CMAKE_FLAGS} -DPRESTO_ENABLE_CUDF=ON"`
 
 In some environments, the CUDA_ARCHITECTURES and CUDA_COMPILER location must be explicitly set.
 The make command will look like:
@@ -139,8 +150,8 @@ The make command will look like:
 The required dependencies are bundled from the Velox setup scripts.
 
 #### Spatial type and function support
-To enable support for spatial types and functions, add to the extra cmake flags:
-`EXTRA_CMAKE_FLAGS = -PRESTO_ENABLE_SPATIAL`
+Spatial type and function support is enabled by default. To disable it, add to `EXTRA_CMAKE_FLAGS` environment variable:
+`export EXTRA_CMAKE_FLAGS="${EXTRA_CMAKE_FLAGS} -PRESTO_ENABLE_SPATIAL=OFF"`
 
 The spatial support adds new types (OGC geometry types) and functionality for spatial calculations.