Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PlatformIO build configurations tweak (resolves universam1/iSpindel#500) #510

Merged
merged 2 commits into from
Jun 18, 2021
Merged

PlatformIO build configurations tweak (resolves universam1/iSpindel#500) #510

merged 2 commits into from
Jun 18, 2021

Conversation

pppedrillo
Copy link
Contributor

Changes to platforio.ini to address #500 issue

  1. Added new build configuration d1_mini_standalone to be able to build from zip without having git installed
  2. d1_mini renamed to d1_mini_git
  3. d1_mini_stage renamed to d1_mini_git_stage

@pppedrillo pppedrillo changed the title PlatformIO build configurations tweak PlatformIO build configurations tweak (resolves #500) Jun 10, 2021
@pppedrillo pppedrillo changed the title PlatformIO build configurations tweak (resolves #500) PlatformIO build configurations tweak (resolves universam1 / iSpindel#500) Jun 10, 2021
@pppedrillo pppedrillo changed the title PlatformIO build configurations tweak (resolves universam1 / iSpindel#500) PlatformIO build configurations tweak (resolves universam1/iSpindel#500) Jun 10, 2021
@universam1 universam1 self-requested a review June 18, 2021 08:28
universam1
universam1 approved these changes Jun 18, 2021
View reviewed changes
Copy link
Owner

@universam1 universam1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see now reason why not to use the git version, but since it's transparent I have no objection to support that

@universam1 universam1 merged commit 0c15104 into universam1:master Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@universam1 universam1 universam1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pppedrillo @universam1