chore: clippy fixes

Signed-off-by: aeryz <[email protected]>

Author: aeryz

cosmwasm/ibc-union/lightclient/sui/src/error.rs

@@ -26,8 +26,8 @@ impl From<Error> for IbcClientError<SuiLightClient> {
     }
 }
 
-impl Into<sui_verifier::Error> for Error {
-    fn into(self) -> sui_verifier::Error {
-        sui_verifier::Error::Client(Box::new(self))
+impl From<Error> for sui_verifier::Error {
+    fn from(value: Error) -> Self {
+        sui_verifier::Error::Client(Box::new(value))
     }
 }

cosmwasm/ibc-union/lightclient/sui/src/verifier.rs

@@ -16,17 +16,14 @@ impl<'a> SignatureVerification for Verifier<'a> {
         msg: &[u8],
         signature: &sui_light_client_types::crypto::AggregateAuthoritySignature,
     ) -> Result<(), Self::Error> {
-        let pubkeys = public_keys
-            .into_iter()
-            .flat_map(|x| x.0)
-            .collect::<Vec<u8>>();
+        let pubkeys = public_keys.iter().flat_map(|x| x.0).collect::<Vec<u8>>();
 
         let aggregate_pubkey = self.deps.api.bls12_381_aggregate_g2(&pubkeys)?;
 
         let hashed_msg =
             self.deps
                 .api
-                .bls12_381_hash_to_g1(HashFunction::Sha256, &msg, Self::BLS_DST)?;
+                .bls12_381_hash_to_g1(HashFunction::Sha256, msg, Self::BLS_DST)?;
 
         let valid = self.deps.api.bls12_381_pairing_equality(
             signature.0.as_ref(),

lib/sui-light-client-types/Cargo.toml

@@ -28,6 +28,7 @@ unionlabs-primitives = { workspace = true, features = ["base58"] }
 
 [dev-dependencies]
 hex-literal = { workspace = true }
+serde       = { workspace = true }
 serde_json  = { workspace = true }
 
 [features]

lib/sui-light-client-types/src/checkpoint_summary.rs

@@ -103,6 +103,7 @@ impl CheckpointContents {
         inner
     }
 
+    #[cfg(feature = "serde")]
     pub fn digest(&self) -> Digest {
         let mut hasher = Blake2b::<typenum::U32>::new();
         hasher.update("CheckpointContents::");

lib/sui-light-client-types/src/crypto.rs

@@ -45,9 +45,9 @@ impl<'de> serde::Deserialize<'de> for SuiBitmap {
         D: serde::Deserializer<'de>,
     {
         let bytes: Vec<u8> = Vec::<u8>::deserialize(deserializer)?;
-        Ok(Self::deserialize_from_bytes(&bytes).map_err(|e| {
+        Self::deserialize_from_bytes(&bytes).map_err(|e| {
             serde::de::Error::custom(format!("byte deserialization failed, cause by: {:?}", e))
-        })?)
+        })
     }
 }
 
@@ -87,8 +87,8 @@ impl<Context> bincode::Decode<Context> for SuiBitmap {
     ) -> Result<Self, bincode::error::DecodeError> {
         let bytes = Vec::<u8>::decode(decoder)?;
 
-        Ok(Self::deserialize_from_bytes(&bytes)
-            .map_err(|e| bincode::error::DecodeError::OtherString(e.to_string()))?)
+        Self::deserialize_from_bytes(&bytes)
+            .map_err(|e| bincode::error::DecodeError::OtherString(e.to_string()))
     }
 }
 

lib/sui-light-client-types/src/object.rs

@@ -14,6 +14,7 @@ pub struct ObjectInner {
 }
 
 impl ObjectInner {
+    #[cfg(feature = "serde")]
     pub fn digest(&self) -> Digest {
         let mut hasher = Blake2b::<typenum::U32>::new();
         hasher.update("Object::");

lib/sui-light-client-types/src/transaction.rs

@@ -15,6 +15,7 @@ pub enum TransactionData {
 }
 
 impl TransactionData {
+    #[cfg(feature = "serde")]
     pub fn digest(&self) -> Bytes<Base58> {
         let mut hasher = Blake2b::<typenum::U32>::new();
         hasher.update("TransactionData::");

lib/sui-light-client-types/src/transaction_effects.rs

@@ -6,8 +6,8 @@ use crate::{checkpoint_summary::GasCostSummary, digest::Digest, ObjectID, Object
 #[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
 #[cfg_attr(feature = "bincode", derive(bincode::Encode, bincode::Decode))]
 pub enum TransactionEffects {
-    V1(TransactionEffectsV1),
-    V2(TransactionEffectsV2),
+    V1(Box<TransactionEffectsV1>),
+    V2(Box<TransactionEffectsV2>),
 }
 
 /// The response from processing a transaction or a certified transaction
@@ -165,6 +165,7 @@ pub enum ExecutionStatus {
 }
 
 impl TransactionEffects {
+    #[cfg(feature = "serde")]
     pub fn digest(&self) -> Digest {
         let mut hasher = Blake2b::<typenum::U32>::new();
         hasher.update("TransactionEffects::");
@@ -175,21 +176,7 @@ impl TransactionEffects {
 
 #[cfg(test)]
 mod tests {
-    use std::str::FromStr;
-
-    use blake2::{Blake2b, Digest as _};
-    use hex_literal::hex;
-    use unionlabs_primitives::{encoding::Base58, Bytes, FixedBytes};
-
     use super::*;
-    use crate::U64;
-
-    fn digest<T: Serialize>(effects: &T) -> Bytes<Base58> {
-        let mut hasher = Blake2b::<typenum::U32>::new();
-        hasher.update("TransactionEffects::");
-        bcs::serialize_into(&mut hasher, effects).unwrap();
-        Bytes::new(hasher.finalize().to_vec())
-    }
 
     #[test]
     fn effects_digest() {
@@ -261,8 +248,9 @@ mod tests {
         .unwrap();
 
         assert_eq!(
-            Bytes::<Base58>::from_str("Fm3buiyN4vxDhnLiwvwDCJ1ZiohH3QCsVGiPCpC96RdR").unwrap(),
-            digest(&TransactionEffects::V2(effect))
+            serde_json::from_str::<Digest>("\"Fm3buiyN4vxDhnLiwvwDCJ1ZiohH3QCsVGiPCpC96RdR\"")
+                .unwrap(),
+            TransactionEffects::V2(Box::new(effect)).digest()
         );
     }
 }

lib/sui-verifier/src/lib.rs

@@ -162,7 +162,7 @@ fn find_write_effect(effects: &TransactionEffects, object: ObjectID) -> Option<D
         TransactionEffects::V2(effects) => effects.changed_objects.iter().find_map(|eff| {
             if eff.0 == object {
                 match &eff.1.output_state {
-                    ObjectOut::ObjectWrite(write) => Some(write.0.clone()),
+                    ObjectOut::ObjectWrite(write) => Some(write.0),
                     _ => None,
                 }
             } else {

voyager/modules/client-bootstrap/sui/src/main.rs

@@ -56,7 +56,7 @@ impl ClientBootstrapModule for Module {
 
         let chain_id = sui_client.read_api().get_chain_identifier().await?;
 
-        info.ensure_chain_id(chain_id.to_string())?;
+        info.ensure_chain_id(&chain_id)?;
         info.ensure_client_type(ClientType::SUI)?;
 
         Ok(Self {