Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add javac plugin #22
base: main
Are you sure you want to change the base?
add javac plugin #22
Changes from 2 commits
d1377f1
2167dd1
6f651f9
ebcebd9
4ea96f4
7f81a5e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this have to have it's own seperate args. also the args should at least match the names of the ones in https://github.com/unimined/JvmDowngrader/blob/main/src/main/java/xyz/wagyourtail/jvmdg/cli/Main.java and maybe share some of the logic.
also, does it really make sense for the classpath for jvmdg to be different than the classpath provided to javac?
also, also, you can pass VM properties into javac somehow, which can also be used to set the jvmdg flags, so is this nececairy at all? https://docs.oracle.com/en/java/javase/17/docs/specs/man/javac.html#option-J
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could make it delegate to
Main
, that would just require a little moving of logic inMain
around so I can get the parsedFlags
. I'm not a particularly big fan of using-J
though, I think having the arguments as the arguments to the plugin would work better.