-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unicode-width should retain a semi-stable width function #64
Comments
@Jules-Bertholet how hard would it be for you to add a |
I think the easy way to do this with the traits would be to add a It's actually unclear to me why we have UnicodeWidthStr and UnicodeWidthChar. |
For perfect stability, we'd have to pin a Unicode version, as the underlying Unicode properties are not stable (even for assigned codepoints). |
I'm fine with it being just EAW and only subject to change with Unicode EAW changes, which change extremely rarely. |
We'd probably want EAW + |
Yeah, sorry, I mean "what we did before", especially since rustfmt relies on this crate. I think given where this crate is in the ecosystem I'd prefer for this option to be readily available. |
As described in #55, 0.1.13 changed the predicted widths of a lot of characters to be more accurate for things like emoji.
From that issue, and from the breakage in rustfmt (rust-lang/rustfmt#6203), it feels useful to have an API that is explicitly stable, and documented as such. Probably one that did the original less-useful-but-"still works" thing of relying on East Asian Width properties only.
The text was updated successfully, but these errors were encountered: