Skip to content

Commit 7a4ea68

Browse files
Merge pull request #3 from githubuser990022/master
Correction on sql
2 parents 261ae67 + 1b3ee79 commit 7a4ea68

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

externallib.php

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -413,11 +413,12 @@ public static function get_grade($gradeitemid, $userid)
413413
$sql = "SELECT gg.id, gi.courseid, gg.finalgrade, gi.iteminstance, gi.itemmodule, a.markingworkflow, asf.workflowstate
414414
FROM {grade_items} gi
415415
INNER JOIN {grade_grades} gg ON gg.itemid = gi.id
416-
INNER JOIN {assign} a ON a.course = gi.courseid AND a.name = gi.itemname
417-
INNER JOIN {assign_user_flags} asf ON asf.assignment = gi.iteminstance
416+
LEFT JOIN {assign} a ON a.course = gi.courseid AND a.id = gi.iteminstance AND gi.itemmodule = :itemmodule
417+
LEFT JOIN {assign_user_flags} asf ON asf.assignment = gi.iteminstance AND asf.userid= gg.userid
418418
WHERE gi.id = :id AND gg.userid = :userid";
419419

420-
$record = $DB->get_record_sql($sql, ['id' => $params['gradeitemid'], 'userid' => $params['userid']], MUST_EXIST);
420+
$record = $DB->get_record_sql($sql, ['id' => $params['gradeitemid'], 'userid' => $params['userid'],
421+
'itemmodule' => 'assign'], MUST_EXIST);
421422

422423
return [
423424
'id' => $record->id,

0 commit comments

Comments
 (0)