Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the optional message form of "to be truthy" and "to be falsy" #670

Open
alexjeffburke opened this issue Dec 7, 2019 · 0 comments

Comments

@alexjeffburke
Copy link
Member

alexjeffburke commented Dec 7, 2019

Normally, the "to be truthy" assertion does not take any value as it simply asserts that a subject can be coerced to a boolean true (in the case of "to be falsy" it is coercion to boolean false).

It seems that early on these assertions inherited an optional form where a custom message can be supplied as their argument - this was likely inspired by earlier assertions frameworks (assert on node still supports forms like this for example).

These two forms of the assertion are at odds with most other assertions where values are consistently used as part of the assertion. Thus, we wish to remove them.

@alexjeffburke alexjeffburke changed the title Remove the optional message form of "to be truthy" and "to be falsy". Remove the optional message form of "to be truthy" and "to be falsy" Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant