Only rely on input shrinking to find the best error

Author: sunesimonsen

lib/unexpected-check.js

@@ -34,18 +34,6 @@
     return {
         name: 'unexpected-check',
         installInto: function (expect) {
-            function convertToUnexpectedError(e) {
-                if (e && e.isUnexpected) {
-                    return e;
-                }
-
-                try {
-                    expect.fail({ message: e.message });
-                } catch (unexpectedError) {
-                    return unexpectedError;
-                }
-            }
-
             expect.addAssertion('<function> to be valid for all <object>', function (expect, subject, options) {
                 var generators = options.generators;
                 var maxIterations = options.maxIterations || 300;
@@ -66,7 +54,7 @@
                         generators = generators.map(function (g, i) {
                             return g.shrink ? g.shrink(args[i]) : g;
                         });
-                        task.error = convertToUnexpectedError(e);
+                        task.error = e
                     }
 
                     return task;
@@ -92,19 +80,7 @@
                 });
 
                 if (failedTasks.length > 0) {
-                    var bestFailure = failedTasks[0];
-                    var currentSize;
-                    failedTasks.forEach(function (task) {
-                        currentSize = currentSize || bestFailure.error.getErrorMessage('text').size();
-                        var newSize = task.error.getErrorMessage('text').size();
-                        if (
-                            (newSize.height < currentSize.height) ||
-                                (newSize.height === currentSize.height && newSize.width < currentSize.width)
-                        ) {
-                            bestFailure = task;
-                            currentSize = newSize;
-                        }
-                    });
+                    var bestFailure = failedTasks[failedTasks.length - 1];
 
                     expect.errorMode = 'bubble';
                     expect.fail(function (output) {

test/unexpected-check.spec.js

@@ -50,13 +50,13 @@ describe('unexpected-check', function () {
                'Ran 20 iterations and found 12 errors\n' +
                'counterexample:\n' +
                '\n' +
-               '  Generated input: [ -15, -20 ]\n' +
+               '  Generated input: [ -20, -15 ]\n' +
                '\n' +
-               '  expected [ -15, -20 ] first item to be less than or equal to all [ -15, -20 ]\n' +
+               '  expected [ -15, -20 ] first item to be less than or equal to all [ -20, -15 ]\n' +
                '\n' +
                '  [\n' +
-               '    -15,\n' +
-               '    -20 // should be greater than or equal to -15\n' +
+               '    -20, // should be greater than or equal to -15\n' +
+               '    -15\n' +
                '  ]');
     });