Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong authorization header upon publishing with creds #56

Closed
skannengiesser opened this issue Jun 19, 2020 · 0 comments · Fixed by #59
Closed

wrong authorization header upon publishing with creds #56

skannengiesser opened this issue Jun 19, 2020 · 0 comments · Fixed by #59

Comments

@skannengiesser
Copy link

skannengiesser commented Jun 19, 2020

I'm configuring helm-publish as follows:

helm {
    publishing {
        repositories {
            artifactory {
                url = uri('https://artifactory.example.com/my-helm-repo')
                credentials {
                    username = 'user'
                    password = 'pass'
                }
            }
        }
    }
}

Instead of the plugin writing the Basic Auth header as:

Authorization: Basic <base64-string> it writes
Authorization: Basic Basic <base64-string>

I think this is of prefixing the response of okhttp3 that also contains "Basic" literal with another "Basic" literal:

.addHeader("Authorization", "Basic ${Credentials.basic(username, password ?: "")}")

@tkrullmann tkrullmann linked a pull request Sep 17, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants