no-duplicates fail positive

[ntnyq]

Repro repo

eslint-plugin-import-x: v4.6.1

ESLint config

import { config, configs  } from 'typescript-eslint'
import pluginImportX from 'eslint-plugin-import-x'

const { createNodeResolver } = pluginImportX

export default config({
  extends: [configs.recommended],
  plugins: {
    'import-x': pluginImportX
  },
  settings: {
    'import-x/resolver-next': [
      createNodeResolver({
        extensions: ['.js', '.mjs', '.ts', '.mts', '.d.ts', '.json'],
      }),
    ],
  },
  rules: {
    'import-x/no-duplicates': ['error']
  }
})

Code:

import { createRouter, createWebHashHistory } from 'vue-router'
import { routes } from 'vue-router/auto-routes'

export const router = createRouter({
  history: createWebHashHistory(),
  routes,
})

Errors:

'/Users/ntnyq/Desktop/github/ntnyq/repro-import-x-no-duplicates/node_modules/.pnpm/[email protected][email protected][email protected]_/node_modules/vue-router/dist/vue-router.mjs' imported multiple times.

With --fix passed, code will change to:

import { createRouter, createWebHashHistory, routes } from 'vue-router'

export const router = createRouter({
  history: createWebHashHistory(),
  routes,
})

[JounQin]

Their import/require conditions point to same file ./dist/vue-router.mjs, so they are considered duplicates.

If you use eslint-import-resolver-typescript, types condition will be preferred, then it should work as expected.

[ntnyq]

Got it. Thanks.

I'll try typescript resolver.