Try catch price value conversion

Author: mattbrailsford

src/Umbraco.Commerce.Deploy/Connectors/ValueConnectors/UmbracoCommercePriceValueConnector.cs

@@ -7,16 +7,35 @@
 using Umbraco.Cms.Core.Deploy;
 using Umbraco.Cms.Core.Models;
 using Umbraco.Cms.Core.Serialization;
+using Umbraco.Commerce.Common.Logging;
 using Umbraco.Commerce.Core.Models;
 using Umbraco.Deploy.Core.Connectors.ValueConnectors;
 
 namespace Umbraco.Commerce.Deploy.Connectors.ValueConnectors
 {
-    public class UmbracoCommercePriceValueConnector(
-        IUmbracoCommerceApi umbracoCommerceApi,
-        IJsonSerializer jsonSerializer)
-        : ValueConnectorBase
+    public class UmbracoCommercePriceValueConnector : ValueConnectorBase
     {
+        private IUmbracoCommerceApi _umbracoCommerceApi;
+        private IJsonSerializer _jsonSerializer;
+        private ILogger<UmbracoCommercePriceValueConnector>? _logger;
+
+        public UmbracoCommercePriceValueConnector(IUmbracoCommerceApi umbracoCommerceApi,
+            IJsonSerializer jsonSerializer,
+            ILogger<UmbracoCommercePriceValueConnector> logger)
+        {
+            _umbracoCommerceApi = umbracoCommerceApi ?? throw new ArgumentNullException(nameof(umbracoCommerceApi));
+            _jsonSerializer = jsonSerializer ?? throw new ArgumentNullException(nameof(jsonSerializer));
+            _logger = logger;
+        }
+
+        public UmbracoCommercePriceValueConnector(IUmbracoCommerceApi umbracoCommerceApi,
+            IJsonSerializer jsonSerializer)
+        {
+            _umbracoCommerceApi = umbracoCommerceApi ?? throw new ArgumentNullException(nameof(umbracoCommerceApi));
+            _jsonSerializer = jsonSerializer ?? throw new ArgumentNullException(nameof(jsonSerializer));
+            _logger = null;
+        }
+
         public override IEnumerable<string> PropertyEditorAliases => new[] { "Umbraco.Commerce.Price" };
 
         public override async Task<string?> ToArtifactAsync(
@@ -33,27 +52,35 @@ public class UmbracoCommercePriceValueConnector(
                 return null;
             }
 
-            Dictionary<Guid, decimal?>? srcDict = jsonSerializer.Deserialize<Dictionary<Guid, decimal?>>(svalue);
+            try
+            {
+                Dictionary<Guid, decimal?>? srcDict = _jsonSerializer.Deserialize<Dictionary<Guid, decimal?>>(svalue);
 
-            var dstDict = new Dictionary<string, decimal?>();
+                var dstDict = new Dictionary<string, decimal?>();
 
-            foreach (KeyValuePair<Guid, decimal?> kvp in srcDict)
-            {
-                var udi = new GuidUdi(UmbracoCommerceConstants.UdiEntityType.Currency, kvp.Key);
+                foreach (KeyValuePair<Guid, decimal?> kvp in srcDict)
+                {
+                    var udi = new GuidUdi(UmbracoCommerceConstants.UdiEntityType.Currency, kvp.Key);
 
-                // Because we store Guid IDs anyway we don't necessarily need to fetch
-                // the Currency entity to look anything up, it's mostly a question
-                // of whether we want to validate the Currency exists. I'm not sure
-                // whether this should really be the responsibility of the property editor
-                // though and we should just be able to trust the property editor value
-                // is valid?
+                    // Because we store Guid IDs anyway we don't necessarily need to fetch
+                    // the Currency entity to look anything up, it's mostly a question
+                    // of whether we want to validate the Currency exists. I'm not sure
+                    // whether this should really be the responsibility of the property editor
+                    // though and we should just be able to trust the property editor value
+                    // is valid?
 
-                dependencies.Add(new UmbracoCommerceArtifactDependency(udi, ArtifactDependencyMode.Exist));
+                    dependencies.Add(new UmbracoCommerceArtifactDependency(udi, ArtifactDependencyMode.Exist));
 
-                dstDict.Add(udi.ToString(), kvp.Value);
-            }
+                    dstDict.Add(udi.ToString(), kvp.Value);
+                }
 
-            return jsonSerializer.Serialize(dstDict);
+                return _jsonSerializer.Serialize(dstDict);
+            }
+            catch (Exception ex)
+            {
+                _logger?.Error(ex, "Failed to serialize price value to artifact: {Value}", svalue);
+                return null;
+            }
         }
 
 
@@ -72,27 +99,36 @@ public class UmbracoCommercePriceValueConnector(
                 return null;
             }
 
-            Dictionary<string, decimal?>? srcDict = jsonSerializer.Deserialize<Dictionary<string, decimal?>>(svalue);
+            try
+            {
+                Dictionary<string, decimal?>? srcDict =
+                    _jsonSerializer.Deserialize<Dictionary<string, decimal?>>(svalue);
 
-            var dstDict = new Dictionary<Guid, decimal?>();
+                var dstDict = new Dictionary<Guid, decimal?>();
 
-            if (srcDict != null)
-            {
-                foreach (KeyValuePair<string, decimal?> kvp in srcDict)
+                if (srcDict != null)
                 {
-                    if (UdiHelper.TryParseGuidUdi(kvp.Key, out GuidUdi? udi) &&
-                        udi!.EntityType == UmbracoCommerceConstants.UdiEntityType.Currency)
+                    foreach (KeyValuePair<string, decimal?> kvp in srcDict)
                     {
-                        CurrencyReadOnly? currencyEntity = await umbracoCommerceApi.GetCurrencyAsync(udi.Guid);
-                        if (currencyEntity != null)
+                        if (UdiHelper.TryParseGuidUdi(kvp.Key, out GuidUdi? udi) &&
+                            udi!.EntityType == UmbracoCommerceConstants.UdiEntityType.Currency)
                         {
-                            dstDict.Add(currencyEntity.Id, kvp.Value);
+                            CurrencyReadOnly? currencyEntity = await _umbracoCommerceApi.GetCurrencyAsync(udi.Guid);
+                            if (currencyEntity != null)
+                            {
+                                dstDict.Add(currencyEntity.Id, kvp.Value);
+                            }
                         }
                     }
                 }
-            }
 
-            return jsonSerializer.Serialize(dstDict);
+                return _jsonSerializer.Serialize(dstDict);
+            }
+            catch (Exception ex)
+            {
+                _logger?.Error(ex, "Failed to deserialize price value from artifact: {Value}", svalue);
+                return null;
+            }
         }
     }
 }