Skip to content

Conversation

@giuunit
Copy link

@giuunit giuunit commented Sep 16, 2024

There was an issue with the TryGetPropertyIndexValue where we could still get a NullRef exception for some edge cases that is fixed now.

I also added a Index value converter for MNTP based on the name that use cache and db call when needed. As it can impact the database I left it outside of the list of default converters so people can decide to pick it or not. Tested in v10.

@giuunit
Copy link
Author

giuunit commented Sep 18, 2024

Hi, is there an opportunity to review my PR ? thank you. It looks like some checks are not successful but I do not believe it is related to my changes. Can someone re run them ?

@acoumb
Copy link
Contributor

acoumb commented Sep 18, 2024

Hi @giuunit ,

The integration comes with a set of default converters but we try to limit that as much as possible, allowing instead for users to register their own as detailed here (or replace one of the existing ones).

So I would recommend you register your SimpleMultinodeTreePickerIndexValueConverter on your side. Adding too many converters by default, for even more complex types in Umbraco, might not suit with everyone using the integration. So I think it's best to keep the scopes isolated.

I will release today patch versions with the fix for the ConverterExtensions helper.

Thank you,
Adrian

@giuunit
Copy link
Author

giuunit commented Sep 18, 2024

thats awesome thank you

@giuunit giuunit closed this Sep 18, 2024
@acoumb acoumb mentioned this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants