Tiptap RTE: Deduplicate extensions to prevent console warnings#21068
Merged
iOvergaard merged 1 commit intomainfrom Dec 8, 2025
Merged
Tiptap RTE: Deduplicate extensions to prevent console warnings#21068iOvergaard merged 1 commit intomainfrom
iOvergaard merged 1 commit intomainfrom
Conversation
…nings When multiple Umbraco extensions (e.g., BulletList and OrderedList) include the same Tiptap extension (ListItem), duplicates were added to the extensions array, causing Tiptap to log warnings. This change uses a Map to deduplicate extensions by their name property before passing them to the Editor. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes console warnings caused by duplicate Tiptap extensions being passed to the Editor. When multiple Umbraco extensions (like BulletList and OrderedList) include the same shared Tiptap extension (like ListItem), duplicates were being added to the extensions array, causing Tiptap to log warnings about duplicate extension names.
The solution implements a Map-based deduplication strategy that collects extensions by their name property before passing them to the Tiptap Editor, ensuring each extension appears only once.
Key changes:
- Changed from array-based collection to Map-based deduplication using extension names as keys
- Updated type import from
ExtensionstoAnyExtensionto better reflect individual extension instances - Implemented "first-wins" deduplication strategy where the first occurrence of an extension is kept
4 tasks
iOvergaard
reviewed
Dec 5, 2025
src/Umbraco.Web.UI.Client/src/packages/tiptap/components/input-tiptap/input-tiptap.element.ts
Show resolved
Hide resolved
iOvergaard
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Deduplicate Tiptap extensions to prevent duplicate name warnings.
When multiple Umbraco extensions (e.g.
BulletListandOrderedList) include the same Tiptap extension (ListItem), duplicates were added to the extensions array, causing Tiptap to log warnings. This change uses aMapto deduplicate extensions by their name property before passing them to the TiptapEditorinstance.🤖 Generated with Claude Code