From b8d8312e82ca544f5dce3ec16ff2e560ef609365 Mon Sep 17 00:00:00 2001 From: leekelleher Date: Mon, 29 Sep 2025 19:09:56 +0100 Subject: [PATCH 1/2] LogViewer: Fixes continuous polling (closes #20274) --- .../log-viewer/workspace/logviewer-workspace.context.ts | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/Umbraco.Web.UI.Client/src/packages/log-viewer/workspace/logviewer-workspace.context.ts b/src/Umbraco.Web.UI.Client/src/packages/log-viewer/workspace/logviewer-workspace.context.ts index 9d7199c471ff..930a14b71438 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/log-viewer/workspace/logviewer-workspace.context.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/log-viewer/workspace/logviewer-workspace.context.ts @@ -124,6 +124,7 @@ export class UmbLogViewerWorkspaceContext extends UmbContextBase implements UmbW override hostDisconnected(): void { super.hostDisconnected(); window.removeEventListener('changestate', this.onChangeState); + this.stopPolling(); } onChangeState = () => { @@ -320,7 +321,7 @@ export class UmbLogViewerWorkspaceContext extends UmbContextBase implements UmbW return; } - clearInterval(this.#intervalID as number); + this.stopPolling(); } setPollingInterval(interval: UmbPoolingInterval) { @@ -332,6 +333,12 @@ export class UmbLogViewerWorkspaceContext extends UmbContextBase implements UmbW const newDirection = direction === DirectionModel.ASCENDING ? DirectionModel.DESCENDING : DirectionModel.ASCENDING; this.#sortingDirection.setValue(newDirection); } + + stopPolling() { + if (this.#intervalID) { + clearInterval(this.#intervalID); + } + } } export { UmbLogViewerWorkspaceContext as api }; From 56ee4bd4fae2fa0306a283b29d692e8f6a84c40a Mon Sep 17 00:00:00 2001 From: Lee Kelleher Date: Mon, 29 Sep 2025 19:14:45 +0100 Subject: [PATCH 2/2] Update src/Umbraco.Web.UI.Client/src/packages/log-viewer/workspace/logviewer-workspace.context.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- .../packages/log-viewer/workspace/logviewer-workspace.context.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Umbraco.Web.UI.Client/src/packages/log-viewer/workspace/logviewer-workspace.context.ts b/src/Umbraco.Web.UI.Client/src/packages/log-viewer/workspace/logviewer-workspace.context.ts index 930a14b71438..2b3c35884903 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/log-viewer/workspace/logviewer-workspace.context.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/log-viewer/workspace/logviewer-workspace.context.ts @@ -337,6 +337,7 @@ export class UmbLogViewerWorkspaceContext extends UmbContextBase implements UmbW stopPolling() { if (this.#intervalID) { clearInterval(this.#intervalID); + this.#intervalID = null; } } }