From f615ca9bf83615f7406fe3caf821ba50320c7cc5 Mon Sep 17 00:00:00 2001 From: Nhu Dinh Date: Wed, 9 Jul 2025 13:39:47 +0700 Subject: [PATCH 1/3] Reverted npx command --- tests/Umbraco.Tests.AcceptanceTest/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Umbraco.Tests.AcceptanceTest/package.json b/tests/Umbraco.Tests.AcceptanceTest/package.json index 98e4c68accde..78d2e8bd9871 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/package.json +++ b/tests/Umbraco.Tests.AcceptanceTest/package.json @@ -9,7 +9,7 @@ "testSqlite": "npx playwright test DefaultConfig --grep-invert \"Users\"", "all": "npx playwright test", "createTest": "node createTest.js", - "smokeTest": "npx playwright test DefaultConfig/Users/Permissions/UserGroup/GranularPermissionsInContent", + "smokeTest": "npx playwright test --grep \"@smoke\"", "smokeTestSqlite": "npx playwright test DefaultConfig --grep \"@smoke\" --grep-invert \"Users\"" }, "devDependencies": { From cd7de1fb71dfd77d2cbf4bdd072378eec1efb75f Mon Sep 17 00:00:00 2001 From: Nhu Dinh Date: Wed, 9 Jul 2025 14:01:08 +0700 Subject: [PATCH 2/3] Fixed npx command --- tests/Umbraco.Tests.AcceptanceTest/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Umbraco.Tests.AcceptanceTest/package.json b/tests/Umbraco.Tests.AcceptanceTest/package.json index 78d2e8bd9871..b2e9ac7ada05 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/package.json +++ b/tests/Umbraco.Tests.AcceptanceTest/package.json @@ -9,7 +9,7 @@ "testSqlite": "npx playwright test DefaultConfig --grep-invert \"Users\"", "all": "npx playwright test", "createTest": "node createTest.js", - "smokeTest": "npx playwright test --grep \"@smoke\"", + "smokeTest": "npx playwright test DefaultConfig --grep \"@smoke\"", "smokeTestSqlite": "npx playwright test DefaultConfig --grep \"@smoke\" --grep-invert \"Users\"" }, "devDependencies": { From 5af8013522e1de1ef3a272ff794faa7f1b9be054 Mon Sep 17 00:00:00 2001 From: Nhu Dinh Date: Wed, 9 Jul 2025 15:35:55 +0700 Subject: [PATCH 3/3] Fixed failed tests related to document type folder --- .../DocumentType/DocumentTypeFolder.spec.ts | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/DocumentType/DocumentTypeFolder.spec.ts b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/DocumentType/DocumentTypeFolder.spec.ts index 691d93051173..c060e0ff2ba4 100644 --- a/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/DocumentType/DocumentTypeFolder.spec.ts +++ b/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/DocumentType/DocumentTypeFolder.spec.ts @@ -23,10 +23,9 @@ test('can create a empty document type folder', {tag: '@smoke'}, async ({umbraco // Assert await umbracoUi.documentType.waitForDocumentTypeToBeCreated(); - const folder = await umbracoApi.documentType.getByName(documentFolderName); - expect(folder.name).toBe(documentFolderName); + expect(await umbracoApi.documentType.doesNameExist(documentFolderName)).toBeTruthy(); // Checks if the folder is in the root - await umbracoUi.documentType.reloadTree('Document Types'); + await umbracoUi.documentType.clickCaretButtonForName('Document Types'); await umbracoUi.documentType.isDocumentTreeItemVisible(documentFolderName); }); @@ -42,7 +41,7 @@ test('can delete a document type folder', {tag: '@smoke'}, async ({umbracoApi, u // Assert await umbracoUi.documentType.waitForDocumentTypeToBeDeleted(); - await umbracoApi.documentType.doesNameExist(documentFolderName); + expect(await umbracoApi.documentType.doesNameExist(documentFolderName)).toBeFalsy(); await umbracoUi.documentType.isDocumentTreeItemVisible(documentFolderName, false); }); @@ -62,8 +61,8 @@ test('can rename a document type folder', async ({umbracoApi, umbracoUi}) => { // Assert await umbracoUi.documentType.waitForDocumentTypeToBeRenamed(); - const folder = await umbracoApi.documentType.getByName(documentFolderName); - expect(folder.name).toBe(documentFolderName); + expect(await umbracoApi.documentType.doesNameExist(oldFolderName)).toBeFalsy(); + expect(await umbracoApi.documentType.doesNameExist(documentFolderName)).toBeTruthy(); await umbracoUi.documentType.isDocumentTreeItemVisible(oldFolderName, false); await umbracoUi.documentType.isDocumentTreeItemVisible(documentFolderName); }); @@ -85,8 +84,7 @@ test('can create a document type folder in a folder', async ({umbracoApi, umbrac // Assert await umbracoUi.documentType.waitForDocumentTypeToBeCreated(); - const folder = await umbracoApi.documentType.getByName(childFolderName); - expect(folder.name).toBe(childFolderName); + expect(await umbracoApi.documentType.doesNameExist(childFolderName)).toBeTruthy(); // Checks if the parentFolder contains the ChildFolder as a child const parentFolder = await umbracoApi.documentType.getChildren(parentFolderId); expect(parentFolder[0].name).toBe(childFolderName);