Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Culture Selection Issue When Duplicating Documents #17736

Closed
martinthogersen opened this issue Dec 5, 2024 · 7 comments
Closed

Culture Selection Issue When Duplicating Documents #17736

martinthogersen opened this issue Dec 5, 2024 · 7 comments
Assignees
Labels

Comments

@martinthogersen
Copy link

martinthogersen commented Dec 5, 2024

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

14.3.1

Bug summary

When duplicating a document available only in specific cultures, the culture settings should persist in the duplicated document.

Example of the Issue:

  1. Original Document:
    Available only in English and Chinese:

image

  1. After Duplication and Publishing:
    When duplicating the document and clicking "Save and Publish," all cultures become selected by default:

image

Additional Feature Request:

  1. Alphabetical Sorting: I suggest sorting the available languages alphabetically in the interface.
  2. Manual Sorting: Alternatively, providing an option for manual sorting of the languages would improve usability.

Specifics

No response

Steps to reproduce

See above.

Expected result / actual result

The duplicated document should retain the same cultures as the original (e.g., only English and Chinese in this case). This functionality was working correctly in Umbraco 13.


This item has been added to our backlog AB#49053

Copy link

github-actions bot commented Dec 5, 2024

Hi there @martinthogersen!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@bergmania
Copy link
Member

Hi.
Thanks for taking the time to suggest these feature. I'll suggest to do it individually in the discussions instead of on the issue tracker.

The behavior is by design and currently, the newly created duplicate do not - and should not IMO - have any knowledge about that is published (or was at the time of duplication) on the original source.

@martinthogersen
Copy link
Author

@bergmania It seems there might be a bug. A similar issue occurs when clicking "Save and Publish" on a page that is already published in some cultures (but not all).

In this scenario, all cultures are selected by default, instead of only the currently published ones. This behavior differs from how it worked in Umbraco 13:

image

In contrast, using Actions → Publish correctly selects only the current culture:

image

As a result, users must manually adjust the list of cultures each time they want to publish a new version. This adds unnecessary steps to the publishing workflow.

@NguyenThuyLan
Copy link
Contributor

NguyenThuyLan commented Feb 13, 2025

Hi @martinthogersen , I tested it on v15.2.1 and now it works correctly as the image below. When Save and Publish, it selects the current variants.
But, with some variants that are not created and not in split view, they are still visible in the list for selection, so here we have a PR for fixing it #18312

Image

@nielslyngsoe nielslyngsoe added the state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks label Feb 13, 2025
@nielslyngsoe nielslyngsoe self-assigned this Feb 13, 2025
@martinthogersen
Copy link
Author

Great 👍

@nielslyngsoe
Copy link
Member

As Lan has highlighted above, this was already partly fixed and the last bits is in place with this PR(#18312) that is merged now, and scheduled for 15.3.

@martinthogersen please let us know about your experience and if there is related cases you think could use some love, thanks in advance.

@martinthogersen
Copy link
Author

Thank you. We'll test this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants