You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now we have a bunch of stuff in Config which make sense for all search algorithms but we don't pass to them in favour of the more specific BanditConfig etc.
It somehow simplifies things because now we can't end up with a wrong config (e.g. a BoundOrder config when we are in bandit code), but it is also annoying because we don't have access to those common config options.
A better way of doing this would be to have a CommonConfig struct with the common config options which we can pass along, and #[serde(flatten)] it into the Config struct to keep the existing fields.
The text was updated successfully, but these errors were encountered:
Right now we have a bunch of stuff in
Config
which make sense for all search algorithms but we don't pass to them in favour of the more specificBanditConfig
etc.It somehow simplifies things because now we can't end up with a wrong config (e.g. a
BoundOrder
config when we are in bandit code), but it is also annoying because we don't have access to those common config options.A better way of doing this would be to have a
CommonConfig
struct with the common config options which we can pass along, and#[serde(flatten)]
it into theConfig
struct to keep the existing fields.The text was updated successfully, but these errors were encountered: