Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binary file not handled correctly by is_dir #23

Open
taebow opened this issue Apr 1, 2021 · 0 comments · May be fixed by #32
Open

Binary file not handled correctly by is_dir #23

taebow opened this issue Apr 1, 2021 · 0 comments · May be fixed by #32

Comments

@taebow
Copy link

taebow commented Apr 1, 2021 •
edited
Loading

https://github.com/ulope/pytest-sftpserver/blob/master/pytest_sftpserver/sftp/content_provider.py#L66

def is_dir(self, path):
    return not isinstance(self.get(path), string_types + integer_types)

It should include has well bytes type.
icemac pushed a commit to sweh/pytest-sftpserver that referenced this issue Jun 30, 2023
Fix is_dir under Python 3:
698d87f 
It is no longer returning `True` for files with binary content.

Fixes ulope#23.
@icemac icemac linked a pull request Jun 30, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix is_dir under Python 3 sweh/pytest-sftpserver
1 participant
@taebow