You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The problem is we use skipLibCheck=false in tsconfig.json.
It looks like the new types are not properly checked in your CI maybe? It also seems they conflict with immutable v3 from which you depend, but in the core package.json you defined v4 ?
Let me know if you need anything more. I did not create a PR to fix it as I don't understand the context of these new types and not sure how to fix it. EDIT: Well, I created #1017 , tell me what you think.
It seems like the issue appears because when you enable skipLibCheck the index.d.ts is totally skipped thus you don't know if your code is correct or not.
You need to enable it for packages that declare an additional .d.ts file.
Describe the bug
New types written in 4.6.1 create conflicts with TS 4.9.5.
I identified the source to be this PR #959.
The problem is we use
skipLibCheck=false
intsconfig.json
.It looks like the new types are not properly checked in your CI maybe? It also seems they conflict with
immutable
v3 from which you depend, but in thecore
package.json you defined v4 ?To Reproduce
https://github.com/ChrisRast/raqb-fix-types
yarn install
or your preferred package manager.yarn typecheck
.Expected behavior
No type conflicts.
Let me know if you need anything more.
I did not create a PR to fix it as I don't understand the context of these new types and not sure how to fix it.EDIT: Well, I created #1017 , tell me what you think.Though one fix I tried was this:
The text was updated successfully, but these errors were encountered: