Skip to content

Commit c54b277

Browse files
authored
Merge pull request #1039 from uken/avoid-to-use-deprecated-parametrized-api
in_elasticsearch: Avoid to use deprecated endpoint for clear_scroll
2 parents 5a78a93 + b137164 commit c54b277

File tree

2 files changed

+12
-3
lines changed

2 files changed

+12
-3
lines changed

lib/fluent/plugin/in_elasticsearch.rb

+5-1
Original file line numberDiff line numberDiff line change
@@ -286,7 +286,11 @@ def run_slice(slice_id=nil)
286286
end
287287

288288
router.emit_stream(@tag, es)
289-
client.clear_scroll(scroll_id: scroll_id) if scroll_id
289+
if Gem::Version.new(Elasticsearch::VERSION) >= Gem::Version.new("7.0.0")
290+
client.clear_scroll(body: {scroll_id: scroll_id}) if scroll_id
291+
else
292+
client.clear_scroll(scroll_id: scroll_id) if scroll_id
293+
end
290294
end
291295

292296
def process_scroll_request(scroll_id)

test/plugin/test_in_elasticsearch.rb

+7-2
Original file line numberDiff line numberDiff line change
@@ -463,9 +463,14 @@ def test_emit_with_size
463463
headers: {'Content-Type' => 'application/json', 'X-elastic-product' => 'Elasticsearch'}}
464464
end
465465
end)
466-
stub_request(:delete, "http://localhost:9200/_search/scroll/WomkoUKG0QPB679Ulo6TqQgh3pIGRUmrl9qXXGK3EeiQh9rbYNasTkspZQcJ01uz").
466+
if Gem::Version.new(Elasticsearch::VERSION) >= Gem::Version.new("7.0.0")
467+
stub_request(:delete, "http://localhost:9200/_search/scroll").
468+
with(body: "{\"scroll_id\":\"WomkoUKG0QPB679Ulo6TqQgh3pIGRUmrl9qXXGK3EeiQh9rbYNasTkspZQcJ01uz\"}").
467469
to_return(status: 200, body: "", headers: {})
468-
470+
else
471+
stub_request(:delete, "http://localhost:9200/_search/scroll/WomkoUKG0QPB679Ulo6TqQgh3pIGRUmrl9qXXGK3EeiQh9rbYNasTkspZQcJ01uz").
472+
to_return(status: 200, body: "", headers: {})
473+
end
469474
driver(CONFIG + %[size 1])
470475
driver.run(expect_emits: 1, timeout: 10)
471476
expected = [

0 commit comments

Comments
 (0)