UAS: Channel Update from manual app installer broken

[Twoure]

When a channel is installed by the manual app installer the branch is set to '' (git.py#L368), which was fine in the past, but now v2.3 requires a branch when updating the channel, or using the update all channels feature (git.py#L223-L253).

Example: git.py#L250
Dict['installed'][bundle]['branch'] returns an empty string, causing a malformed URL.

Side Note: Re-using the migrate channels function does not auto-fill the missing branch info.

[ukdtom]

Not sure I get what you are saying here?

Doing a manual install of a bundle, not in UAS, will set the branch dir to master

Like this get shows:
http://PMS_IP:33400/webtools2?module=git&function=list

{ "https://github.com/jwsolve/Afdah.bundle": { "description": "", "title": "Afdah", "bundle": "Afdah.bundle", "CommitId": "55fb786bb9", "branch": "master", "date": "2016-10-26 19:30:19", "identifier": "com.plexapp.plugins.afdah", "type": [ "Unknown" ], "icon": "" } }

However, if doing a "Factory Reset", will make WebTools loose track of the install source, when migrated back in, and has always been so.

Is that what you perhaps is seen?

[Twoure]

Sorry, you are right. The current version (and possibly the previous version) will set the branch to master when using the manual app installer.

My issue may be from an older version of the WT (I guess). For some reason many of my previously manually installed channels do not have the branch set. They are all GitHub channels that are not included within the UAS (hence manual). I can go through each one and remove them, then re-add them so the branch is set properly, but is a pain (as I have ~45 manually installed channels). Especially when some of those channels have Dict data I'd like not to lose.

Note:

• I've never preformed a WT "Factory Reset"
• Installed WT once, (at v2.0), and updated manually until the new WT updater, then used the internal updater only

[ukdtom]

I'll see what I can do here ;-)

[ukdtom]

And would it be possible for you to post a dump of your current dict?
Just if anything else is missing here

[Twoure]

And would it be possible for you to post a dump of your current dict?

Yes: wt-dict.zip

[ukdtom]

Care to test the Issue-214 branch?

/T

[Twoure]

Tested the Issue-214 branch, but found git.py#L244 was True for my affected bundles. Fixed the fix in a pull request #217 😉. I understand not using the pull and just editing the file yourself.

[ukdtom]

Fix checked into a45d8f9