Mean to inst field names, part I #1925
Merged
zach1221 merged 142 commits intoOct 10, 2023
Merged
Conversation
on-behalf-of @ufs-community <jong.kim@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
update cmeps build to implement check4nans feature using module stored in cdeps repo
Collaborator
Author
|
I am running the logs now after the two dependent PRs have been merged. |
Collaborator
Ok, great. We can start this PR once your tests are finished. Edit: let's wait, and get 1925 done before 1907. |
Collaborator
Author
|
I made a boo-boo running the logs and need to start over :-( |
Collaborator
Ah, yes. It happens to us all. All good. |
Collaborator
|
Jenkins-ci ORTs passed |
Collaborator
Author
|
@zach1221 When you squash merge, can you make the commit message just this |
BrianCurtis-NOAA
approved these changes
Oct 10, 2023
sadeghitabas
approved these changes
Oct 10, 2023
Collaborator
Yes, I can. |
42 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Author Checklist:
Description
Changes some field names going TO ATM from CICE or CMEPS to remove "mean" prefix. Also renames the FV3 export fields prec,fprec and prec_rate_conv as
instrather thanmean.This is the first part of a 2 part commit sequence to change from mean->inst field names. This first part will not change baselines against those created using the second of the two dependent PRs.
Logs will be posted once the dependent PRs have been merged.
Linked Issues and Pull Requests
Associated UFSWM Issue to close
Subcomponent Pull Requests
Blocking Dependencies
Subcomponents involved:
Anticipated Changes
Input data
Regression Tests:
Tests effected by changes in this PR:
Libraries
Code Managers Log
Testing Log: