Skip to content

Regression Testing Updates#1675

Closed
BrianCurtis-NOAA wants to merge 42 commits into
ufs-community:developfrom
BrianCurtis-NOAA:rtupdates
Closed

Regression Testing Updates#1675
BrianCurtis-NOAA wants to merge 42 commits into
ufs-community:developfrom
BrianCurtis-NOAA:rtupdates

Conversation

@BrianCurtis-NOAA

@BrianCurtis-NOAA BrianCurtis-NOAA commented Mar 23, 2023

Copy link
Copy Markdown
Collaborator

Description

rt.conf updates:

  • Combine Intel and GNU tests into one conf file.
  • Added section to COMPILE line to hard-code compile numbers.
  • Added section to COMPILE line to specify compiler.

rt.sh updates:

  • Fixes for some identified potential issues in scripts. Output text should be less repetative.
  • Removal of INTEL/GNU baseline develop dirs.
  • Test Run Dir's names updated with which compiler is being used.

Log updates:

  • RegressionTests_.log and opnReqTest_.log now go into log directory.
  • Log files now RegressionTests_<machine>.log instead of RegressionTests_<machine>.<compiler>.log.

Baseline storage updates:

  • develop-2023XXXX/INTEL|GNU/<test_dir> now are just develop-2023XXXX/<test_dir>.
  • Run/Test Dir's now have RT_COMPILER appended to them (i.e. control_c48_intel and control_c48_gnu).
  • STMP/PTMP baseline storage now REGRESSION_TEST instead of REGRESSION_TEST_INTEL or REGRESSION_TEST_GNU.

opnReqTest updates:

  • Tests that are not compatible yet with ORT tests like dcmp, thrd, fhzero etc, will now auto skip themselves instead of failing the whole suite. So running ORT should be as easy as ./opnReqTest -e -n regional_control

PR template update:

  • The PR template was updated to what is shown here. Removed the Intel/GNU sections from Testing Log.

Input data additions/changes

  • No changes are expected to input data.
  • Changes are expected to input data:
    • New input data.
    • Updated input data.

Anticipated changes to regression tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:

This should not change answers to any test, but the whole regression testing system is getting name changes, so all baselines will need to be regenerated with the new code changes and new baseline-dirs will need to be created.

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Combined with PR's (If Applicable):

Commit Queue Checklist:

  • Link PR's from all sub-components involved in section below
  • Confirm reviews completed in ALL sub-component PR's
  • Add all appropriate labels to this PR.
  • Run full RT suite on either Hera/Cheyenne AND attach log to a PR comment.
  • Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Linked PR's and Issues:

Testing Day Checklist:

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

  • RDHPCS
    • Hera
    • Orion
    • Jet
    • Gaea
    • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

…r easy navigating during compile failures during testing
@BrianCurtis-NOAA BrianCurtis-NOAA added the Baseline Updates Current baselines will be updated. label Apr 3, 2023
@BrianCurtis-NOAA

Copy link
Copy Markdown
Collaborator Author

OpnReqTests_regional_control_hera.log
opnReqTest confirmation of success with changes.

@BrianCurtis-NOAA

Copy link
Copy Markdown
Collaborator Author

Superceded by #1718

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Baseline Updates Current baselines will be updated.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Combine Intel/GNU tests && hard code compile number in rt.conf

1 participant