From 341b743ec6f2fc67ee2ee778a8dbe69c02038649 Mon Sep 17 00:00:00 2001
From: "samuel.trahan" <Samuel.Trahan@noaa.gov>
Date: Tue, 5 Jul 2022 22:00:53 +0000
Subject: [PATCH 1/2] Bug fix for #1309: false reports of test failures

---
 tests/run_compile.sh | 18 +++++++++++++-----
 tests/run_test.sh    | 18 +++++++++++++-----
 2 files changed, 26 insertions(+), 10 deletions(-)

diff --git a/tests/run_compile.sh b/tests/run_compile.sh
index ed7ae7ce11..c7eaa83676 100755
--- a/tests/run_compile.sh
+++ b/tests/run_compile.sh
@@ -23,6 +23,15 @@ write_fail_test() {
   exit 1
 }
 
+remove_fail_test() {
+    echo "Removing test failure flag file for compile_${COMPILE_NR}"
+    if [[ ${OPNREQ_TEST} == true ]] ; then
+        rm -f $PATHRT/fail_opnreq_test_${COMPILE_NR}
+    else
+        rm -f $PATHRT/fail_test_${COMPILE_NR}
+    fi
+}
+
 if [[ $# != 4 ]]; then
   echo "Usage: $0 PATHRT RUNDIR_ROOT MAKE_OPT COMPILE_NR"
   exit 1
@@ -35,11 +44,7 @@ export COMPILE_NR=$4
 
 cd ${PATHRT}
 OPNREQ_TEST=${OPNREQ_TEST:-false}
-if [[ ${OPNREQ_TEST} == true ]]; then
-  rm -f fail_opnreq_compile_${COMPILE_NR}
-else
-  rm -f fail_compile_${COMPILE_NR}
-fi
+remove_fail_test
 
 [[ -e ${RUNDIR_ROOT}/compile_${COMPILE_NR}.env ]] && source ${RUNDIR_ROOT}/compile_${COMPILE_NR}.env
 source default_vars.sh
@@ -85,6 +90,9 @@ ls -l ${PATHTR}/tests/fv3_${COMPILE_NR}.exe
 
 cp ${RUNDIR}/compile_*_time.log ${LOG_DIR}
 cat ${RUNDIR}/job_timestamp.txt >> ${LOG_DIR}/job_${JOB_NR}_timestamp.txt
+
+remove_fail_test
+
 ################################################################################
 # End compile job
 ################################################################################
diff --git a/tests/run_test.sh b/tests/run_test.sh
index 0f996a7c09..9617810f27 100755
--- a/tests/run_test.sh
+++ b/tests/run_test.sh
@@ -23,6 +23,15 @@ write_fail_test() {
   exit 1
 }
 
+remove_fail_test() {
+    echo "Removing test failure flag file for ${TEST_NAME} ${TEST_NR}"
+    if [[ ${OPNREQ_TEST} == true ]] ; then
+        rm -f $PATHRT/fail_opnreq_test_${TEST_NR}
+    else
+        rm -f $PATHRT/fail_test_${TEST_NR}
+    fi
+}
+
 function compute_petbounds() {
 
   # each test MUST define ${COMPONENT}_tasks variable for all components it is using
@@ -90,11 +99,7 @@ export COMPILE_NR=$5
 
 cd ${PATHRT}
 OPNREQ_TEST=${OPNREQ_TEST:-false}
-if [[ ${OPNREQ_TEST} == true ]]; then
-  rm -f fail_opnreq_test_${TEST_NR}
-else
-  rm -f fail_test_${TEST_NR}
-fi
+remove_fail_test
 
 [[ -e ${RUNDIR_ROOT}/run_test_${TEST_NR}.env ]] && source ${RUNDIR_ROOT}/run_test_${TEST_NR}.env
 source default_vars.sh
@@ -356,6 +361,9 @@ fi
 if [[ $SCHEDULER != 'none' ]]; then
   cat ${RUNDIR}/job_timestamp.txt >> ${LOG_DIR}/job_${JOB_NR}_timestamp.txt
 fi
+
+remove_fail_test
+
 ################################################################################
 # End test
 ################################################################################

From 6b311f74dbbc7c425f352847235bcdf8aa95c32c Mon Sep 17 00:00:00 2001
From: "samuel.trahan" <Samuel.Trahan@noaa.gov>
Date: Wed, 6 Jul 2022 16:29:27 +0000
Subject: [PATCH 2/2] remove the _compile_ file instead of _test_ in
 run_compile.sh

---
 tests/run_compile.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/run_compile.sh b/tests/run_compile.sh
index c7eaa83676..4ec17c9edf 100755
--- a/tests/run_compile.sh
+++ b/tests/run_compile.sh
@@ -26,9 +26,9 @@ write_fail_test() {
 remove_fail_test() {
     echo "Removing test failure flag file for compile_${COMPILE_NR}"
     if [[ ${OPNREQ_TEST} == true ]] ; then
-        rm -f $PATHRT/fail_opnreq_test_${COMPILE_NR}
+        rm -f $PATHRT/fail_opnreq_compile_${COMPILE_NR}
     else
-        rm -f $PATHRT/fail_test_${COMPILE_NR}
+        rm -f $PATHRT/fail_compile_${COMPILE_NR}
     fi
 }