[develop]: Document process for changing number of vertical levels#888
Merged
Conversation
Co-authored-by: Michael Kavulich <kavulich@ucar.edu>
Co-authored-by: Michael Kavulich <kavulich@ucar.edu>
Co-authored-by: Michael Kavulich <kavulich@ucar.edu>
Co-authored-by: Michael Kavulich <kavulich@ucar.edu>
…er-app into text/ug-updates
Co-authored-by: Michael Kavulich <kavulich@ucar.edu>
…er-app into text/ug-updates
JeffBeck-NOAA
approved these changes
Sep 2, 2023
JeffBeck-NOAA
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for all your work on this PR, @gspetro-NOAA!
MichaelLueken
approved these changes
Sep 6, 2023
MichaelLueken
left a comment
Collaborator
There was a problem hiding this comment.
@gspetro-NOAA - Thank you very much for going into great detail on how to change the number of vertical levels in the SRW App! These changes look good to me! Approving now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
This PR adds a section to the LAMGrid chapter explaining how to change the number of vertical levels in an SRW App experiment
Type of change
TESTS CONDUCTED:
None required. This is a documentation-only PR. However, I ran through an experiment using the process in the docs to generate ak/bk for 128 levels. I used the resulting VCOORD_FILE to run the
community.config.yamlexperiment with 128 vertical levels instead of the usual 65. The workflow completed successfully and the results can be viewed on Hera here:/scratch2/NAGAPE/epic/Gillian.Petro/expt_dirs/test_vert2The human-friendly version of the docs in my fork can be viewed here: https://srw-ug.readthedocs.io/en/text-grid/CustomizingTheWorkflow/LAMGrids.html.
DEPENDENCIES:
PR #880
DOCUMENTATION:
N/A (all docs)
ISSUE:
It seems that PR #813 and the updates in this PR at least partially resolve Issue #397.
I think there was the hope that we could simplify the process for users (e.g., by setting
levp/npzand other required variables inconfig.yamland generating the ak/bk automatically from that), so it may be best to check with @JeffBeck-NOAA and @gsketefian as to whether to close this issue and open an enhancement issue or just keep this issue open.CHECKLIST