diff --git a/ush/generate_FV3LAM_wflow.py b/ush/generate_FV3LAM_wflow.py index 16a2a6342..2391340c4 100755 --- a/ush/generate_FV3LAM_wflow.py +++ b/ush/generate_FV3LAM_wflow.py @@ -512,7 +512,7 @@ def generate_FV3LAM_wflow(): CRONTAB_LINE = \"{CRONTAB_LINE}\"''',verbose=VERBOSE) if MACHINE == "WCOSS_DELL_P3": - run_command(f'''printf "%s" '{CRONTAB_LINE}' >> f"/u/{USER}/cron/mycrontab"''') + run_command(f'''printf "%s\n" '{CRONTAB_LINE}' >> "/u/{USER}/cron/mycrontab"''') else: # Add a newline to the end of crontab_contents only if it is not empty. # This is needed so that when CRONTAB_LINE is printed out, it appears on diff --git a/ush/get_crontab_contents.py b/ush/get_crontab_contents.py index 8316e7c7d..cbb434c69 100644 --- a/ush/get_crontab_contents.py +++ b/ush/get_crontab_contents.py @@ -38,9 +38,9 @@ def get_crontab_contents(called_from_cron): print_input_args(locals()) #import all env vars - IMPORTS = ["MACHINE"] + IMPORTS = ["MACHINE", "USER"] import_vars(env_vars=IMPORTS) - + # # Make sure called_from_cron is set to a valid value. # @@ -79,5 +79,5 @@ def test_get_crontab_contents(self): self.assertEqual(crontab_cmd, "crontab") def setUp(self): define_macos_utilities(); - set_env_var('DEBUG','FALSE') + set_env_var('DEBUG',False) set_env_var('MACHINE', 'HERA') diff --git a/ush/retrieve_data.py b/ush/retrieve_data.py index 86cb87e07..0b65597be 100755 --- a/ush/retrieve_data.py +++ b/ush/retrieve_data.py @@ -716,7 +716,6 @@ def parse_args(): output = subprocess.run('which hsi', check=True, shell=True, - capture_output=True, ) except subprocess.CalledProcessError: logging.error('You requested the hpss data store, but ' \ diff --git a/ush/setup.py b/ush/setup.py index 3584656eb..cd90f7066 100644 --- a/ush/setup.py +++ b/ush/setup.py @@ -428,7 +428,7 @@ def setup(): # #----------------------------------------------------------------------- global USE_MERRA_CLIMO - if USE_MERRA_CLIMO == "FV3_GFS_v15_thompson_mynn_lam3km": + if CCPP_PHYS_SUITE == "FV3_GFS_v15_thompson_mynn_lam3km": USE_MERRA_CLIMO=True # #-----------------------------------------------------------------------