Fix else-statement bug in make_orog task; fix model_config bug for ensemble forecasts; remove obsolete physics suites; get WE2E tests to run on cheyenne#287
Merged
gsketefian merged 11 commits intoSep 14, 2020
Conversation
…1beta. Modifications common to more than one file: ------------------------------------------ (A) Wrap actions that should occur only for the RRFS_v1beta suite inside if-statements that checkwhether this suite is being used. (B) Fix indentation. File-by-file modifications: -------------------------- scripts/exregional_make_orog.sh: (A) scripts/exregional_run_fcst.sh: * Clean up comments. tests/baseline_configs/config.FV3_RRFS_v1beta.sh: * Change the location for the orog files needed by the RRFS_v1beta suite to something more official rather than a use directory (for hera). ush/link_fix.sh: (A), (B) ush/setup.sh: (B)
…eration bug (see below). List of modifications: --------------------- * In scripts/exregional_run_fcst.sh, remove lines that, for the case of ensemble forecasts, create a link in the run directory to a model configure file in the cycle directory (which is one level up from the run directory). These were previously needed but no longer are. That's because in the current version of the workflow, the model configure files are always created directly in the run directory (whereas in previous versions, for ensemble forecasts only one model_configure file was created for each cycle that was pointed to by all members of the ensemble for that cycle). * Remove physics suites FV3_GSD_SAR_v1 and FV3_RRFS_v0 because they are no longer part of the ufs-weather-model repo. This entails: * Removing the names of these suites from the list of valid suite values in valid_param_vals.sh (in the variable valid_vals_CCPP_PHYS_SUITE). * Deleting the corresponding WE2E tests (regional_013 and regional_016). * Removing the names of these suites from the list of WE2E tests in baselines_list.txt. * Change the permissions of the WE2E configuration file config.user_download_extrn_files.sh so that it is not an executable file (it doesn't need to be; it just gets sourced). * Add the FV3_RRFS_v1beta suite to the list of WE2E tests in baselines_list.txt. * Remove the WE2E test user_download_extrn_files from the list in baselines_list.txt because that test starts to download data during the generate step, so any tests that come after this one have to wait for the download to complete before being generated. * Fix comments in ush/create_model_config_file.sh. * Delete unneeded file ush/create_modle_config_files.sh. * Reorder the remaining suites in the variable valid_vals_CCPP_PHYS_SUITE in valid_param_vals.sh alphabetically.
… and other files since they are no longer in ufs-weather-model.
gsketefian
requested review from
BenjaminBlake-NOAA,
JeffBeck-NOAA,
JulieSchramm,
RatkoVasic-NOAA and
mkavulich
…del_configure_file(.sh) because the file that this function creates is called model_configure, not model_config.
Collaborator
Author
|
This has been successfully tested on hera. Please test on other platforms if you like. Otherwise, it's ready to merge (simultaneously with PR#24 into ufs-community/ufs-srweather-app. |
Collaborator
|
Testing on Jet now. |
…ded by the WE2E test FV3_RRFS_v1beta are located.
gsketefian
added
Tested on Hera
… than the GSD_HRRR3km one (so it completes quickly). It was inadvertently set to GSD_HRRR3km. Change it back to GSD_HRRR25km.
JeffBeck-NOAA
approved these changes
Sep 11, 2020
JeffBeck-NOAA
left a comment
JeffBeck-NOAA
left a comment
Collaborator
There was a problem hiding this comment.
@gsketefian After a successful build of the release/public-v2 FV3 code, two tests succeeded on Jet: one with FV3_GSD_SAR, another with FV3_RRFS_v1beta, the second with staged orog files. I updated the RRFS_v1beta baseline test with the following:
#On jet:
#GWD_RRFS_v1beta_BASEDIR="/lfs4/BMC/wrfruc/FV3LAM_pregen/orog"
@gsketefian Feel free to update the baseline test with these lines and merge your two PRs.
…ng where the orography statistics files needed by this physics suite are located on jet.
…Want to transfer this to hera before looking at all the changes carefully using xxdiff.
gsketefian
changed the title
Collaborator
Author
|
The WE2E tests passed on both hera and cheyenne, so I'm going to merge this. @JulieSchramm to run the tests on cheyenne, you need to change STMP and PTMP in the file tests/run_experiments.sh. I haven't gotten around to making those arguments to the script yet. Please let me know if you need help. |
gsketefian
referenced
this pull request
in ufs-community/ufs-srweather-app
Sep 14, 2020
… of authoritative repo; update physics suites for which to build FV3 (#24) This PR must be merged simultaneously with PR#[287](https://github.com/NOAA-EMC/regional_workflow/pull/287) into NOAA-EMC/regional_workflow. Summary of Modifications: ------------------------ * In Externals.cfg: * Update the source of the ufs_weather_app external to be the release/public-v2 branch of the ufs-community/ufs-weather-model repo (which is the authoritative repo). * Update the regional_workflow external so it points to the HEAD of the develop branch of the NOAA-EMC/regional_workflow repo. * In build_forecast.sh, add the suites FV3_GFS_2017_gfdlmp_regional and FV3_RRFS_v1beta to the list of suites for which to build the forecast model.
christinaholtNOAA
pushed a commit
to christinaholtNOAA/regional_workflow
that referenced
this pull request
Apr 27, 2022
…le to run directory before run the model. (ufs-community#287)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR must be merged simultaneously with PR#24 into ufs-community/ufs-srweather-app which contains updates to the external repo hashes and the physics suites for which to build the forecast model.
DESCRIPTION OF CHANGES:
Bugs fixed:
Other modifications:
TESTS CONDUCTED:
Ran all 26 WE2E tests both on hera and cheyenne. 24 of the 26 succeeded. Details:
Note that the FV3_RRFS_v1beta suite was also tested on the GSD_HRRR3km grid. This failed at around hour 4 (for a 6-hour forecast) with a very non-informative error. This test was also tried previously with hash 8165575 from the NCAR fork of ufs-weather-model (in the dtc/develop branch), and that finished successfully. Not clear what changed between these two versions of ufs-weather-model.
OTHER CONTRIBUTORS:
@JeffBeck-NOAA