Perils of rm -fr $builddir

[rpdelaney]

Thanks for this. I was recently lamenting the lack of anything like this tool.

bashvm/bin/bashvm-install

Line 28 in 1b020ea

rm -rf $builddir

This is dangerous.

1. Since $builddir isn't quoted, chaos will ensue if this ever becomes subject to word splitting for any reason. C.f.: bumblebeee
2. since you don't have set -u, who knows what will happen if the variable is unset when we get to this point? C.f.: steam-for-linux and shellcheck (I'm not really recommending set -u btw)
3. Globs and wildcards in the path will be expanded by the shell before rm is called, leading to some kind of apocalypse probably.

You may think that the code as-written can't be subject to such problems. But a future refactoring elsewhere could render this unsafe.

If you agree I can send a PR adding some safety catches. What do you think?