Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Cypress testing suite #3789

Closed
5 tasks
bdbch opened this issue Feb 24, 2023 · 0 comments · Fixed by #3817
Closed
5 tasks

Improve Cypress testing suite #3789

bdbch opened this issue Feb 24, 2023 · 0 comments · Fixed by #3817
Assignees
Labels
Type: Bug The issue or pullrequest is related to a bug
Milestone

Comments

@bdbch
Copy link
Member

bdbch commented Feb 24, 2023

What’s the bug you are facing?

Currently our Cypress test suite is running on Github CI and take around 30 minutes to finish. Those are currently running on all branches and on each commit. Also tests are failing randomly because the headless browser is not finding specific elements which should be there after the grace time of 10s.

Open Tasks

  • Adjust Github CI
    • Only run on main and release-* branches
    • Only run on PRs when a PR was approved
  • Refactor tests to run more performant
  • Fix performance issues in combination with Github CI and the headless browser

Other notes

We also thought about adding unit tests specifically for the core and ui library packages to test helper and core functions and classes which could run more frequently.

Testing specific frameworks would also be a nice addition as a test on release-* branches so we can test if Tiptap is correctly installed in various setups.

Those could include

  • Next.js
  • CRA
  • Vite
  • Nuxt
  • Vanilla Webpack

This could avoid future issues with broken builds with said frameworks.

@bdbch bdbch added the Type: Bug The issue or pullrequest is related to a bug label Feb 24, 2023
@bdbch bdbch self-assigned this Feb 24, 2023
@bdbch bdbch added this to the 2.0.0 Release milestone Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug The issue or pullrequest is related to a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant