Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bubble Menu disappears for split second after clicking item #3625

Closed
1 of 2 tasks
dominiczy opened this issue Jan 13, 2023 · 6 comments
Closed
1 of 2 tasks

Bubble Menu disappears for split second after clicking item #3625

dominiczy opened this issue Jan 13, 2023 · 6 comments
Labels
Info: Stale The issue or pullrequest has not been updated in a while and might be stale Type: Bug The issue or pullrequest is related to a bug

Comments

@dominiczy
Copy link

What’s the bug you are facing?

I'm using Vite + React + TipTap. I've added a minimal implementation of the Bubble Menu. However, when clicking any Bubble Menu item that executes an editor command, the bubble menu disappears while the command is executed, and then reappears.
This is a bad user experience. I believe it's a bug since it's not present in the TipTap's own Bubble Menu example.

Minimal reproduction of the bug: https://stackblitz.com/edit/vitejs-vite-vdekmz?file=src%2FApp.jsx

Which browser was this experienced in? Are any special extensions installed?

Chrome, no extensions

How can we reproduce the bug on our side?

Reproduction at https://stackblitz.com/edit/vitejs-vite-vdekmz?file=src%2FApp.jsx

Can you provide a CodeSandbox?

https://stackblitz.com/edit/vitejs-vite-vdekmz?file=src%2FApp.jsx

What did you expect to happen?

Bubble Menu stays visible all the time

Anything to add? (optional)

No response

Did you update your dependencies?

  • Yes, I’ve updated my dependencies to use the latest version of all packages.

Are you sponsoring us?

  • Yes, I’m a sponsor. 💖
@dominiczy dominiczy added the Type: Bug The issue or pullrequest is related to a bug label Jan 13, 2023
@dominiczy
Copy link
Author

dominiczy commented Jan 13, 2023

Not sure if this is a cause or a symptom (I suspect the latter), but I've noticed the aria-expanded attribute of the Tiptap editor div becomes false for a split second at the same time the bubble menu disappears. Again, that doesn't happen in Tiptap's own example

image

@popdo
Copy link

popdo commented Feb 5, 2023

The button on the bubble menu will not have such a problem if you use button

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2023

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Info: Stale The issue or pullrequest has not been updated in a while and might be stale label May 7, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 14, 2023
@kongweiying2
Copy link

I'm also getting this issue. If a command is run, then it does this disappearing and then reappearing. If the command is disabled, then it's fine. @dominiczy Did you manage to find a solution?

@kongweiying2
Copy link

kongweiying2 commented Jun 15, 2023

The button on the bubble menu will not have such a problem if you use button

Actually this is strange, there's no flashing if I use an ordinary element like <button>. Not quite sure how to resolve this.

@jmtimko5
Copy link

I still see this when using ordinary button elements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Info: Stale The issue or pullrequest has not been updated in a while and might be stale Type: Bug The issue or pullrequest is related to a bug
Projects
None yet
Development

No branches or pull requests

4 participants