.can() returns false for extension-list even when the command is runnable

[C-Hess]

What’s the bug you are facing?

The .can() command is a bit overzealous for the list extension. If the cursor/selection is on an existing list or heading element, the can() command returns false for toggleBulletList() and toggleOrderedList() commands. However, these commands are still executable, and can/will replace the current node with the new list node type selected.

Which browser was this experienced in? Are any special extensions installed?

• Chrome
• Bullet lists
• Ordered lists
• Headings

How can we reproduce the bug on our side?

1. Open the sandbox
   1. The sandbox is similar to the demo. The only difference is that the buttons are disabled if the can() command for the corresponding controls returns false
2. Create a bullet or ordered list with one item in the list
3. Note that the other list type and heading are disabled
4. Create another list item at the same level
5. Note that if the second list item in a list is selected with the cursor, they are enabled again
6. Nest the second list item with the tab key
7. Note that if two list items exist, but the cursor is on the first list item, the header is disabled 😕

Can you provide a CodeSandbox?

https://codesandbox.io/s/frosty-goldwasser-visq8r?file=/src/App.tsx

What did you expect to happen?

The .can() command should accurately reflect whether a command is possible to run given the editor state. In this case, because it is totally possible to switch between lists or convert a list to a heading, the .can() command should return true for all of the described cases above.

Anything to add? (optional)

It's possible that the heading being disabled when the nested list item is selected is a separate issue, but I figured I'd leave it here in case it's the same. Otherwise, let me know, and I can open another issue

This issue is related to #3223, but that pr fixes issues with the .can() command for marks

Did you update your dependencies?

• Yes, I’ve updated my dependencies to use the latest version of all packages.

Are you sponsoring us?

• Yes, I’m a sponsor. 💖

[github-actions]

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 7 days

[bkempe]

This is still an issue

[corbinschwartz]

Also running into this, repro steps in original description are accurate.

#3026 looks potentially related:

• since dispatch is now false instead of undefined when passing to

  tiptap/packages/core/src/CommandManager.ts

  Line 119 in 998e6bb

  public buildProps(tr: Transaction, shouldDispatch = true): CommandProps {

• which causes shouldDispatch to now be false (instead of defaulting to true when passed undefined)
• which then causes dispatch to be undefined when it gets to

  tiptap/packages/core/src/commands/toggleList.ts

  Line 99 in 998e6bb

  && dispatch

[Goodosky]

The same problem occurs with setHeading() and toggleHeading()

If the selection is on an existing list, both commands are runnable, but .can() returns false.

This issue has been around for some time: #4225 (comment)