Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Cypress tests more reliable and faster #3193

Closed
1 of 2 tasks
bdbch opened this issue Sep 13, 2022 · 2 comments
Closed
1 of 2 tasks

Make Cypress tests more reliable and faster #3193

bdbch opened this issue Sep 13, 2022 · 2 comments
Assignees
Labels
Info: Stale The issue or pullrequest has not been updated in a while and might be stale Type: Bug The issue or pullrequest is related to a bug

Comments

@bdbch
Copy link
Member

bdbch commented Sep 13, 2022

What’s the bug you are facing?

The Cypress tests have two major problems from what I can see:

  1. They are super slow resulting in a slow response time to potential test failures. This could be maybe improved but we'll have to check how
  2. The tests are sometimes failing because the chrome renderer didn't render in time. This causes tests to sometimes fail in between different runs without reason.

Both issues result in tests not being a reliable way to point out potential breaking bugs.

Which browser was this experienced in? Are any special extensions installed?

How can we reproduce the bug on our side?

Can you provide a CodeSandbox?

No response

What did you expect to happen?

The tests should run faster - maybe by just running tests for changed files. I don't know if this is possible with Cypress but it's worth to investigate.

Tests should also run reliable - this is something where I'm not sure how to solve it. In the past I tried to push up the wait time which totally bloated test times.

If we can somehow combine both solutions (or maybe find a way to tell Cypress to always wait for the document to finish loading with a running Tiptap instance) would be great.

Anything to add? (optional)

No response

Did you update your dependencies?

  • Yes, I’ve updated my dependencies to use the latest version of all packages.

Are you sponsoring us?

  • Yes, I’m a sponsor. 💖
@bdbch bdbch added the Type: Bug The issue or pullrequest is related to a bug label Sep 13, 2022
@bdbch bdbch added this to the 2.0.0 milestone Sep 13, 2022
@bdbch bdbch self-assigned this Sep 13, 2022
@mattvb91
Copy link

Not sure if its related but I am currently struggling trying to test my application:

CypressError: Timed out retrying after 4050ms: `cy.click()` failed because this element is detached from the DOM.
`<div contenteditable="true" translate="no" tabindex="0" class="ProseMirror">...</div>`
Cypress requires elements be attached in the DOM to interact with them.

Even when changing the selectors around the rerender is always causing cypress to fail. Really difficult to track down

@github-actions
Copy link
Contributor

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Info: Stale The issue or pullrequest has not been updated in a while and might be stale label May 28, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Info: Stale The issue or pullrequest has not been updated in a while and might be stale Type: Bug The issue or pullrequest is related to a bug
Projects
None yet
Development

No branches or pull requests

2 participants